Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Corrected name and comments as advised by reviewer.

Related to Issue [MWDAM-1115]

Corrected tests as advised by reviewer.

Related to Issue [MWDAM-1115]

Implement design options in writing XML data from DAM UI to in DAM Engine

Related to Issue [MWDAM-1092]

    • -0
    • +30
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
Corrected tests as advised by reviewer.

Related to Issue [MWDAM-1115]

Added test as requested by reviewer.

Related to Issue [MWDAM-1098]

Further simplified use of redesignedSurfaceLine as only one can exists per result anyway. So now only one (in global and local form)is used instead of one for piping and one for stability (with their local and global forms).

Related to Issue [MWDAM-1115]

    • -14
    • +2
    ./Dam/Forms/DamSpatialEditorDecorator.cs
Added code to read the stability design parameters from the engine output and to add these to the UI-data. Although there is a unit test for this, the real testing can only take place once the whole "train" (UI-Engine-kernel) is in place.

Related to Issue [MWDAM-1115]

    • -59
    • +261
    ./Dam/Tests/DamEngineIo/FillDamUiFromXmlOutputTests.cs
Made sure that properties which depend on the surface line now use the proper surface lines. This is: where possible the correct GLOBAL redesigned surface line (all parts of coordinates should be returned in the same global reference system). Note that for this case "Current" properties are meant to be original properties based on the original surface line rather than the redesigned surface line.

Related to Issue [MWDAM-1115]

    • -109
    • +106
    ./Dam/Data/CsvExportData.cs
Removed Category("Calculation") as advised by Tom to actually see these tests on the buildserver.

Related to Issue [MWDAM-1035]

Fixed the piping benchmark tests for as far these are relevant (Sellmeijer2Forces and Wti2017 are not (yet) supported).

Related to Issue [MWDAM-1035]

    • -0
    • +8
    ./Dam/Tests/Deltares.Dam.BenchmarkTests.csproj
    • -66
    • +108
    ./Dam/Tests/DamPipingBenchmarkTest.cs
Made sure SoilProfile is set too on filling CsvExportData. Made sure the results are properly displayed in the UI (by properly clearing old results, making sure new results are properly propagated to table and property window). Cleaned up CsvExportData a bit. For piping, the results now seem to be ok.

Related to Issue [MWDAM-1035]

    • -3
    • +7
    ./Dam/Data/DamFailureMechanismeCalculationSpecification.cs
    • -169
    • +171
    ./Dam/Data/CsvExportData.cs
Added soil parameters to UI

Related to Issue [MWDAM-1099]

    • -0
    • +79
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
Replaced null propagation (?.) by explicit test on null as this seems not supported by VS 2012.

Related to Issue [MWDAM-1098]

Implemented the parameters for this option in the UI.

Related to Issue [MWDAM-1098]

    • -0
    • +145
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
Improved unit tests

Related to Issue [MWDAM-1094]

Implement passing calculationmessages in Dam UI

Related to Issue [MWDAM-1094]

    • -0
    • +36
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
Implemented the parameters for this option in the UI.

Related to Issue [MWDAM-1084]

    • -0
    • +45
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
Adapted to review

Related to Issue [MWDAM-1083]

  1. … 1 more file in changeset.
Adapted to review

- Added comment headers

Related to Issue [MWDAM-1091]

    • -0
    • +3
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
  1. … 1 more file in changeset.
Removed all nwo related code , tests and test files.

Related to Issue [MWDAM-1096]

    • too large
    ./Dam/Tests/TestData/DamLive/Set3/output.damx
    • -57
    • +0
    ./Dam/Tests/NonWaterRetainingObjectTest.cs
    • -158
    • +0
    ./Dam/Data/NonWaterRetainingObject.cs
    • -31
    • +1
    ./Dam/Data/Properties/Settings.Designer.cs
    • too large
    ./Dam/Tests/TestData/DamLive/Grebbedijk/input.damx
    • -43
    • +0
    ./Dam/Tests/Deltares.Dam.IntegrationTests.csproj
    • -97
    • +0
    ./Dam/Tests/DamStabilityNWOIntegrationTest.cs
    • -341
    • +0
    ./Dam/Tests/NonWaterRetainingObjectInSurfaceLineTest.cs
  1. … 29 more files in changeset.
Change code to be VS2012 compliant

Related to Issue [MWDAM-1075]

  1. … 2 more files in changeset.
Fixed to review: Add extra validations

Related to Issue [MWDAM-1075]

Fixed to review: comment headers updated

Related to Issue [MWDAM-1079]

    • -2
    • +2
    ./Dam/Data/DamEngineIo/ConversionHelper.cs
Code cleanup

Related to Issue [MWDAM-1091]

Prevent error with RedesignedSurfaceLine2Piping in case of Design, Adaptgeometry.

Related to Issue [MWDAM-1035]

    • -1
    • +4
    ./Dam/Forms/DamSpatialEditorDecorator.cs
Made sure CalculationResult is read only.

Related to Issue [MWDAM-1035]

Increased performance by disabling events. Made sure results are set for scenario as well so they can be shown in the UI.

Related to Issue [MWDAM-1035]

Removed obsolete data.

Related to Issue [MWDAM-1035]

Only transfer selected locations throught the interface to the Dam Engine

Related to Issue [MWDAM-1051]

Added check on redesigned surface line actually being available; extended the test to include piping design results.

Related to Issue [MWDAM-1035]