John Bokma

About
  • First commit 22 March 2016
  • Latest commit 04 April 2025
Last Week All Time
Commits: 5 1,329
Files changed: 15 18,262
Change in LOC: 531 2,838,219

Reviews

28 active reviews

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

John Bokma is mapped to 2 committers over 2 repositories
Username bka is mapped to:
Today
3 hrs ago

John Bokma

Added some more code for conversion.

Related to Issue [MWDAM-2208]

Options
    • -3
    • +96
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityInterfaceInputFromEngine.cs
Thursday 03 Apr
4:20 pm

John Bokma

Added two files to be able to create to the MAC kernel directly instead of using the C# wrapper.

Related to Issue [MWDAM-2208]

Options
    • -0
    • +176
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/InterfaceConversionHelper.cs
    • -0
    • +248
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/FillMacroStabilityInterfaceInputFromEngine.cs
12:23 pm

John Bokma

Corrected typo in comment.

Related to Issue [MWDAM-2208]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Interfaces/IKernelDataInput.cs
Monday 31 Mar
3:32 pm

John Bokma

Added tolerance to test to solve error.

Related to Issue [MWDAM-2208]

Options
    • -10
    • +12
    /DamClients/DamUI/trunk/src/Dam/Deltares.Dam.IntegrationTests/FailureMechanismTests.cs
1:46 pm

John Bokma

Moved adapting surfaceline to a higher level (surfaceline instead of geometrypointstring) to prevent removing "real" characteristic points (i.e. other than type = None). Cleaned code a bit.

Related to Issue [MWDAM-2208]

Options
    • -0
    • +9
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometrySurface.cs
    • -2
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/SoilProfile2DHelper.cs
    • -16
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
    • -25
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
    • -8
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -3
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -1
    • +55
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorSingle.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
Thursday 27 Mar
2:56 pm

John Bokma

Adapted surfaceline and geometry input for kernel by getting rid of points that are alomost the same which (sometimes) leads to accuracy problems in the kernel.

Related to Issue [MWDAM-2208]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
    • -6
    • +6
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -0
    • +16
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
    • -0
    • +25
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/CheckLargeResultsSets.cs
    • -3
    • +8
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryData.cs
Friday 21 Mar
6:24 pm

John Bokma

Adapted test value as that is what I find with 1 Core as does Trp and TC. So original value must be wrong.

Related to Issue [MWDAM-2208]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/MultiCoreMacroStabilityInwardsTests.cs
4:37 pm

John Bokma

Readded the zigzag tests (as WIP) as requested by Trp.

Related to Issue [MWDAM-2677]

Options
    • -0
    • +28
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -0
    • +300
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
Thursday 20 Mar
2:49 pm

John Bokma

Removed obsolete parameters and class.

Related to Issue [MWDAM-2208]

Options
    • -10
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapperTests.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/General/Parallel.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityOutwards/MacroStabilityOutwardsKernelWrapper.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedFailedDesignInputFile_1Location.xml
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapper.cs
    • -62
    • +12
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -10
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
    • -4
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingBligh/WtiPipingBlighKernelWrapper.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/UpliftHelperTests.cs
    • -8
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingBligh/WtiPipingBlighKernelWrapperTests.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/UpliftHelper.cs
    • -44
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/Location.cs
    • -0
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
  16. … 4 more files in changeset.
Wednesday 19 Mar
1:25 pm

John Bokma

Removed obsolete RiverLever from Location (is now part of CurrentScenario).

Related to Issue [MWDAM-2208]

Options
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
    • -12
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/Location.cs
Friday 14 Mar
12:15 pm

John Bokma

Removed the shift from the datamodel of the Engine.

Related to Issue [MWDAM-2708]

Options
    • -2
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -8
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/Location.cs
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/DamPipingHelper.cs
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/UpliftHelper.cs
11:25 am

John Bokma

Set XSoilGeometry2DOrigin to 0 for all locations just to make a point ;-). All shifted values as they should be for the geometry were already adapted for issues MWDAM-2677 and MWDAM-2701.

Related to Issue [MWDAM-2707]

Options
    • too large
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/TestFiles/InputTutorialStability2D.xml
10:58 am

John Bokma

Adapted to review comments.

Related to Issue [MWDAM-2764]

Options
    • -16
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DTests.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/PlLinesCreator/SoilProfileValidatorTests.cs
Thursday 13 Mar
5:46 pm

John Bokma

Commit of the two now fixed tests.

Related to Issue [MWDAM-2764]

Options
    • -24
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
11:53 am

John Bokma

Removed GeometryPoint from GeometryPointString/GeometryLoop classes and everywhere it was used. Improved geometry generation and Clone() methods for SoilProfile2D.

Related to Issue [MWDAM-2760]

Options
    • -8
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/GeometryExport/GeometryExporter.cs
    • -27
    • +26
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/CharacteristicPointSet.cs
    • -6
    • +6
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineSlopeAdapter.cs
    • -0
    • +9
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/Point2D.cs
    • -29
    • +29
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SurfaceLine2.cs
    • -112
    • +35
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/DamPipingHelper.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -9
    • +9
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorShoulderPerPoint.cs
    • -1
    • +68
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -4
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -3
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/Uplift/UpliftLocationAndResult.cs
    • -9
    • +9
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +18
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilProfile2D.cs
    • -63
    • +59
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
  16. … 41 more files in changeset.
11:10 am

John Bokma

Commit of all tests adapted to removal of geometry point from loop/geometrypointstring.

Related to Issue [MWDAM-2764]

Options
    • -17
    • +17
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
    • -187
    • +199
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/PlLinesToWaternetConverterTests.cs
    • -230
    • +230
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineSlopeAdapterTest.cs
    • -12
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/Factories/FactoryForSurfaceLines.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/GeometryExporterTests.cs
    • -0
    • +68
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DTests.cs
    • -38
    • +15
    /DamEngine/trunk/src/Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs
    • -14
    • +10
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Interface.Tests/ConversionHelperTests.cs
    • -4
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geometry/GeometryDataTests.cs
    • -24
    • +24
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile2DSurfaceLineHelperTests.cs
    • -36
    • +33
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/SurfaceLine2Tests.cs
  16. … 14 more files in changeset.
Wednesday 12 Mar
11:01 am

John Bokma

Remove obsolete classes using obsolete GeometryPoints from GeometryPointString/GeometryLoop.

Related to Issue [MWDAM-2760]

Options
    • -36
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/CoordinateSystemConverterException.cs
    • -283
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/CoordinateSystemConverter.cs
Thursday 06 Mar
1:59 pm

John Bokma

Adapted to review comments.

Related to Issue [MWDAM-2258]

Options
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilProfile2DSurfaceLineHelper.cs
Wednesday 05 Mar
4:22 pm

John Bokma

Extended tests, cleaned up code.

Related to Issue [MWDAM-2690]

Options
    • -23
    • +44
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geometry/GeometryGeneratorTests.cs
    • -122
    • +192
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
1:36 pm

John Bokma

Oops, and now without the debug code.

Related to Issue [MWDAM-2690]

Options
    • -8
    • +8
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
1:27 pm

John Bokma

Fixed DWP_6 and DWP_7 problems

Related to Issue [MWDAM-2690]

Options
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
    • -8
    • +8
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
Tuesday 04 Mar
5:09 pm

John Bokma

DWP_8 and DWP_20 now succeed (Full test still as WIP due to DWP_6 and 7).

Related to Issue [MWDAM-2400]

Options
    • -51
    • +15
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/IntegrationTests/IssuesTests.cs
3:00 pm

John Bokma

Make sure XSoilGeometry2DOrigin is set to 0.0 so it can not provide a shift anymore

Related to Issue [MWDAM-2708]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -5
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
2:55 pm

John Bokma

Adapted the generator a little, added tests.

Related to Issue [MWDAM-2648]

Options
    • -15
    • +450
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geometry/GeometryGeneratorTests.cs
    • -20
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
11:47 am

John Bokma

Updated the xml file after adding shift to UI.

Related to Issue [MWDAM-2701]

Options
    • too large
    /DamEngine/trunk/src/Deltares.DamEngine.IntegrationTests/TestFiles/InputTutorialStability2D.xml
Friday 28 Feb
6:00 pm

John Bokma

Reverted the changes as they were commited by mistake.

Related to Issue [MWDAM-2701]

Options
    • too large
    /DamClients/DamUI/trunk/data/benchmarks/Piping/Test 3/Integratietest piping 3.damx
    • too large
    /DamClients/DamUI/trunk/data/benchmarks/Piping/Test 4/Integratietest piping 4.damx
    • too large
    /DamClients/DamUI/trunk/data/benchmarks/Piping/Test 5/Integratietest piping 5.damx
    • -6
    • +5
    /DamClients/DamUI/trunk/data/benchmarks/Piping/Readme.txt
3:39 pm

John Bokma

Updated for change in validator LooseCurves for GeometryData.

Related to Issue [MWDAM-2701]

Options
    • binary
    /DamClients/DamLive/trunk/lib/DSL-GeoIO/Deltares.Soilbase.dll
    • binary
    /DamClients/DamLive/trunk/lib/DSL-GeoIO/Deltares.Geometry.dll
    • binary
    /DamClients/DamLive/trunk/lib/DSL-Geo/Deltares.Geometry.dll
    • binary
    /DamClients/DamLive/trunk/lib/DSL-Geo/Deltares.Geotechnics.dll
    • binary
    /DamClients/DamLive/trunk/lib/DSL-GeoIO/Deltares.Geotechnics.IO.dll
    • binary
    /DamClients/DamLive/trunk/lib/DSL-GeoIO/Deltares.Geotechnics.dll
2:01 pm

John Bokma

Corrected tests for adapted validation.

Related to Issue [MWDAM-2701]

Options
    • -7
    • +2
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.StixFileReader.Tests/StixFileReaderTest.cs
    • -7
    • +2
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.StixFileReader.Tests/SoilProfile2DDataModelTest.cs
1:22 pm

John Bokma

Removed local validator.

Related to Issue [MWDAM-2701]

Options
    • -2
    • +2
    /DamClients/DamUI/trunk/src/Dam/Deltares.Dam.Tests/Geometry2DImporter/SoilProfile2DImporterTest.cs
    • -72
    • +0
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Geometry2DImporter/SoilProfile2DImporter.cs
1:13 pm

John Bokma

Updated for change in validator LosseCurves for GeometryData.

Related to Issue [MWDAM-2701]

Options
    • binary
    /DamClients/DamUI/trunk/lib/DSL-GeoIO/Deltares.Geotechnics.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-GeoIO/Deltares.Soilbase.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-Geo/Deltares.Geometry.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-GeoIO/Deltares.Geometry.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsGeo/Deltares.Geometry.Forms.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-Geo/Deltares.Geotechnics.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-GeoIO/Deltares.Geotechnics.IO.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsGeo/Deltares.Geotechnics.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsGeo/Deltares.Geometry.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsGeo/Deltares.Geotechnics.Forms.dll