Deltares.DamEngine.Calculators

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sonarcloud issues solved

Related to Issue [MWDAM-2771]

Sonarcloud issues solved

Related to Issue [MWDAM-2771]

  1. … 1 more file in changeset.
Double conversion removed to keep all diameters in meter

Related to Issue [MWDAM-2771]

  1. … 1 more file in changeset.
DamPipingHelper renamed into WtiPipingHelper

Related to Issue [MWDAM-2771]

  1. … 2 more files in changeset.
DamPiping renamed into WtiPiping (folders + classes + variables)

Related to Issue [MWDAM-2771]

    • -85
    • +0
    ./KernelWrappers/Common/DamPipingHelper.cs
    • -0
    • +85
    ./KernelWrappers/Common/WtiPipingHelper.cs
  1. … 2 more files in changeset.
DamPiping renamed into WtiPiping (folders + classes)

Related to Issue [MWDAM-2771]

    • -0
    • +403
    ./KernelWrappers/WtiPipingBligh/WtiPipingBlighKernelWrapper.cs
    • -0
    • +81
    ./KernelWrappers/WtiPipingBligh/WtiPipingBlighOutput.cs
    • -0
    • +79
    ./KernelWrappers/WtiPipingBligh/WtiPipingBlighInput.cs
  1. … 2 more files in changeset.
DamPiping dll is replaced with WtiPiping dll for Bligh calculation

Related to Issue [MWDAM-2771]

    • -3
    • +0
    ./Deltares.DamEngine.Calculators.csproj
  1. … 5 more files in changeset.
Fixed putting through the error message when design fails

Fixed design with 1D profiles

Related to Issue [MWDAM-2670]

PL1 creator from sensors corrected (Point DikeToeAtPolder not created if SourceType is Ignore or if no Polder Sensor present).

Unit tests adapted according to change.

Related to Issue [MWDAM-2766]

    • -36
    • +11
    ./PlLinesCreator/SensorPlLine1Creator.cs
  1. … 1 more file in changeset.
previous change reverted because makes the code unclear

Related to Issue [MWDAM-2767]

    • -2
    • +10
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Sonarcloud issues solved

Related to Issue [MWDAM-2767]

    • -10
    • +2
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Add SlipCircle Output for Bishop to TimeSeries.

Related to Issue [MWDAM-2560]

    • -0
    • +8
    ./DikesOperational/OperationalCalculator.cs
  1. … 8 more files in changeset.
Removed the shift from the datamodel of the Engine.

Related to Issue [MWDAM-2708]

    • -1
    • +1
    ./Uplift/UpliftLocationDeterminator.cs
    • -2
    • +1
    ./KernelWrappers/Common/DamPipingHelper.cs
    • -2
    • +1
    ./KernelWrappers/Common/UpliftHelper.cs
  1. … 3 more files in changeset.
Sonarcloud issues solved

Related to Issue [MWDAM-2767]

    • -12
    • +17
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 6 more files in changeset.
Removed GeometryPoint from GeometryPointString/GeometryLoop classes and everywhere it was used. Improved geometry generation and Clone() methods for SoilProfile2D.

Related to Issue [MWDAM-2760]

    • -6
    • +6
    ./DikesDesign/SurfaceLineSlopeAdapter.cs
    • -2
    • +2
    ./KernelWrappers/Common/DamPipingHelper.cs
    • -1
    • +1
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -9
    • +9
    ./DikesDesign/DesignCalculatorShoulderPerPoint.cs
    • -9
    • +9
    ./Uplift/UpliftLocationDeterminator.cs
    • -8
    • +31
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
    • -2
    • +2
    ./PlLinesCreator/SoilProfileValidator.cs
    • -21
    • +21
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -15
    • +4
    ./PlLinesCreator/SensorPlLineCreatorBase.cs
  1. … 41 more files in changeset.
Unwanted validation error (about exponent m) returns by macrostability is avoided

Related to Issue [MWDAM-2762]

  1. … 1 more file in changeset.
unit tests added on lower level + code improved

Related to Issue [MWDAM-2691]

    • -56
    • +64
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 2 more files in changeset.
Test for 2D profile is updated (shoulder and ditch added) and comparison is extended to the Pl lines of both profiles and both time steps

Related to Issue [MWDAM-2706]

    • -1
    • +1
    ./PlLinesCreator/SensorPlLine1Creator.cs
  1. … 4 more files in changeset.
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

Unit test added using the data provided by RPS in issue MWDAM_2631.

Code corrected for searching the intersection point with PL1.

Unused property XSoilGeometry2DOrigin removed from PlLinesCreator.

Related to Issue [MWDAM-2631]

    • -3
    • +1
    ./KernelWrappers/Common/PlLinesHelper.cs
  1. … 21 more files in changeset.
Removed obsolete code

Related to Issue [MWDAM-2160]

    • -38
    • +0
    ./KernelWrappers/Assemblers/MissingRequiredFieldValueException.cs
    • -47
    • +0
    ./KernelWrappers/Assemblers/EmbeddedResourceNotFoundException.cs
    • -80
    • +0
    ./KernelWrappers/Assemblers/Common.cs
    • -38
    • +0
    ./KernelWrappers/Assemblers/DtoAssemblerConversionException.cs
    • -363
    • +0
    ./KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
  1. … 4 more files in changeset.
Code improved according to sonarcloud issue

Related to Issue [MWDAM-2691]

    • -11
    • +3
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Waternet line associated to an empty PL line (no points) is not created

Related to Issue [MWDAM-2733]

  1. … 1 more file in changeset.
Code for the PL3/PL4 reduction re-implemented and improved (1D soil profile is not converted to 2D soil profile to spare calculation time).

Integration tests for piping updated with the new results.

Related to Issue [MWDAM-2691]

    • -58
    • +76
    ./PlLinesCreator/PlLinesCreator.cs
  1. … 3 more files in changeset.
code temporary reverted due to execution timeout

Related to Issue [MWDAM-2691]

Reduction of PL3/PL4 temporary reverted to better investigate the piping failing tests (execution time out)

Related to Issue [MWDAM-2691]

  1. … 1 more file in changeset.
Test is corrected and WIP is removed

Related to Issue [MWDAM-2462]

  1. … 1 more file in changeset.
Adapted to review: method starting with Get renamed into Determine

Related to Issue [MWDAM-2724]

    • -2
    • +2
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
    • -3
    • +3
    ./DikesDesign/SurfaceLineHeightAdapter.cs
  1. … 2 more files in changeset.
Reduction of PL3/PL4 implemented when the aquifer intersects the surface line (i.e. the ditch)

Related to Issue [MWDAM-2691]

    • -13
    • +103
    ./PlLinesCreator/PlLinesCreator.cs
    • -0
    • +41
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 3 more files in changeset.
Fix SonarCloud issues

Related to Issue [MWDAM-2548]

  1. … 1 more file in changeset.