Deltares.DamEngine.Calculators

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
In-between aquifers situated at the left side of DikeToeAtPolder are not taken into account.

Unit tets added.

Related to Issue [MWDAM-2720]

  1. … 2 more files in changeset.
Sonarcloud issues fixed

Related to Issue [MWDAM-2716]

    • -30
    • +25
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
Waternet lines for in-between aquifer cluster with vertical part is improved by connecting the points to create a unique line

Related to Issue [MWDAM-2716]

    • -10
    • +41
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 1 more file in changeset.
Validation performed in PlLinesCreator removed because duplication of the validation performed in ValidateSoilProfileForPlLinesCreation

Related to Issue [MWDAM-2724]

    • -5
    • +3
    ./DikesDesign/SurfaceLineHeightAdapter.cs
    • -87
    • +22
    ./PlLinesCreator/PlLinesCreator.cs
    • -4
    • +2
    ./DikesDesign/SurfaceLineShoulderAdapter.cs
  1. … 4 more files in changeset.
Fix unit test

Related to Issue [MWDAM-2474]

Reformat and Cleanup

Related to Issue [MWDAM-2474]

Fixed using the leading calculation (Uplift or Bishop) when designing

Related to Issue [MWDAM-2474]

  1. … 1 more file in changeset.
Determination of the top and bottom aquifers improved in case of cluster.

Unit tests added.

Related to Issue [MWDAM-2716]

    • -61
    • +80
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 1 more file in changeset.
Adapted to review: refactored

Related to Issue [MWDAM-2474]

Determination of the boundaries of the in-between aquifers improved to deal with in-between aquifers cutting the not vertical geometry limit.

Unit test added.

Related to Issue [MWDAM-2716]

    • -83
    • +129
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
  1. … 4 more files in changeset.
Reimplemented remove shift, removed from xml-comments.

Related to Issue [MWDAM-2677]

Adapted to review: comment added to explain why the inner loops are removed

Related to Issue [MWDAM-2704]

Reimplemented remove shift.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
  1. … 4 more files in changeset.
Added Su Table to Dam Engine TD. Update mapping of Soil.

Related to Issue [MWDAM-2711]

  1. … 1 more file in changeset.
Reverted remove shift until UI is OK.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
  1. … 6 more files in changeset.
Update DamEngine with StixFileWriter rev.118

Related to Issue [MWDAM-2545]

    • -1
    • +1
    ./Deltares.DamEngine.Calculators.csproj
  1. … 2 more files in changeset.
Removed using shift as that should be a task in the UI, not in the engine.

Related to Issue [MWDAM-2677]

    • -1
    • +1
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
  1. … 5 more files in changeset.
Code improved and header in public method added

Related to Issue [MWDAM-2704]

    • -3
    • +1
    ./PlLinesCreator/SoilProfileValidator.cs
    • -1
    • +11
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
For the validation of the soil profile, an aquifer with aquitard inner loop is valid

Related to Issue [MWDAM-2704]

    • -2
    • +42
    ./KernelWrappers/Common/SoilProfile2DHelper.cs
    • -1
    • +3
    ./PlLinesCreator/SoilProfileValidator.cs
  1. … 1 more file in changeset.
Add design result message to output when design fails

Related to Issue [MWDAM-2474]

  1. … 1 more file in changeset.
Fix handling when design is unsuccessful

Related to Issue [MWDAM-2474]

    • -0
    • +4
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
  1. … 2 more files in changeset.
Connect DamEngine with Mac Kernel.

Related to Issue [MWDAM-2575]

  1. … 2 more files in changeset.
Fix Adapt geometry optimized slope and shoulder adjustment

Related to Issue [MWDAM-2474]

    • -4
    • +2
    ./DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -2
    • +2
    ./DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
  1. … 1 more file in changeset.
Clean-up in MStabParameters.cs : obsolete parameters removed

Related to Issue [MWDAM-2565]

  1. … 6 more files in changeset.
Adapted to review

Related to Issue [MWDAM-2643]

    • -2
    • +3
    ./Uplift/UpliftLocationDeterminator.cs
Reverted revision(s) 5774 from :

Fix sonarcloud Reliability issue: Use a comparison to 'default(TDomainObject)' instead or add a constraint to 'TDomainObject' so that it can't be a value type.

Related to Issue [MWDAM-2643]

........

Fix sonarcloud Reliability issue: Use a comparison to 'default(TDomainObject)' instead or add a constraint to 'TDomainObject' so that it can't be a value type.

Related to Issue [MWDAM-2643]

Fix sonarcloud Reliability issues: Do not check floating point equality with exact values, use a range instead

Related to Issue [MWDAM-2643]

    • -1
    • +3
    ./Uplift/UpliftLocationDeterminator.cs
Adapted to review: obsolete parameter IsTangentLinesAutomatic for Bishop removed

Related to Issue [MWDAM-2665]

  1. … 1 more file in changeset.
Removed properties from Location that are duplicated in DesignScenario

Related to Issue [MWDAM-2649]

    • -2
    • +2
    ./KernelWrappers/Common/PlLinesHelper.cs
  1. … 10 more files in changeset.