Riskeer / Ringtoets / HydraRing

test

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Jan 2019
9:39 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1927

Options
    • -4
    • +23
    ./Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicBoundaryDatabaseReader/emptyGeneral.sqlite
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicBoundaryDatabaseReader/emptySchemaGeneral.sqlite
  4. … 3 more files in changeset.
Tuesday 15 Jan 2019
1:59 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3445: WTI-1925

- Cleaned up code

- Moved logging from the importer to the update helper

-- Cleaned up resources

-- Cleaned up tests

Options
    • -5
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
  2. … 10 more files in changeset.
Friday 11 Jan 2019
11:43 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Added ArgumentException when the read hydraulic location configuration database contains multiple or zero items for the database settings.

-- Added factory and factory methods to verify behaviour

-- Renamed factory methods to be more representative

- Updated logic in the importer

Options
    • -0
    • +48
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseSettingsTestFactoryTest.cs
    • -2
    • +24
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -0
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil.Test/Ringtoets.HydraRing.IO.TestUtil.Test.csproj
    • -0
    • +43
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseSettingsTestFactory.cs
    • -7
    • +20
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
    • -0
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil/Ringtoets.HydraRing.IO.TestUtil.csproj
  7. … 6 more files in changeset.
11:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Made ReadTrackId public. WTI-1927

Options
    • -0
    • +53
    ./Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
  2. … 1 more file in changeset.
9:51 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Refactored test factory and extracted private creation method to prevent code duplication.

- Renamed test

Options
    • -4
    • +3
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -13
    • +15
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
9:12 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Removed the IsScenarioInformationPresent flag from the read object.

Options
    • -2
    • +0
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -4
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -4
    • +0
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -2
    • +0
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
  5. … 7 more files in changeset.
8:58 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Return NULL when the ScenarioInformation table is missing for the read file.

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
  2. … 1 more file in changeset.
8:56 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3443: WTI-1925

- Changed Assert.Zero() and .NotZero() to Assert.AreEqual(0, ..) and .NotEqual(0, ...) for consistency reasons throughout the code

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicBoundaryDatabaseTestFactoryTest.cs
  2. … 4 more files in changeset.
Wednesday 09 Jan 2019
3:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3442: WTI-1486

- Performed minor cleanup

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicBoundaryDatabaseTestFactoryTest.cs
  2. … 1 more file in changeset.
Tuesday 08 Jan 2019
4:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation error in test. WTI-1925

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
3:49 pm

Dennis Tang <dennis.tang@deltares.nl>

Fixed compilation error after rebase. WTI-1925

Options
    • -0
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
2:30 pm

Dennis Tang <dennis.tang@deltares.nl>

Added factory method: WTI-1925

- Added factory method to create a read object with scenario information

-- Done as preparation to be used for the UpdateHandler tests

Options
    • -0
    • +28
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -1
    • +27
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
2:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Renamed read object for the HydraulicLocationConfigurationDatabaseSetting. WTI-1924

- Combination of values is a setting

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -0
    • +86
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseSettingTest.cs
    • -86
    • +0
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseSettingsTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
  6. … 5 more files in changeset.
2:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Revert "Renamed read object for the HydraulicLocationConfigurationDatabaseSetting. WTI-1924"

This reverts commit 0ef1f694c47138757331af02c3947dc13f085fff.

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -86
    • +0
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseSettingTest.cs
    • -0
    • +86
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseSettingsTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
    • -6
    • +6
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
  7. … 5 more files in changeset.
2:07 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1486

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicBoundaryDatabaseTestFactoryTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
  4. … 4 more files in changeset.
1:57 pm

Dennis Tang <dennis.tang@deltares.nl>

Added missing asserts to the test factory. WTI-1925

Options
    • -0
    • +6
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
1:32 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1486

Options
    • -3
    • +3
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicBoundaryDatabaseTestFactory.cs
    • -2
    • +2
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
  3. … 3 more files in changeset.
10:52 am

Dennis Tang <dennis.tang@deltares.nl>

Moved queries and column names: WTI-1925

- Moved string values to their dedicated classes to prevent code duplication.

Options
    • -1
    • +26
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseQueryBuilderTest.cs
    • -2
    • +2
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -0
    • +46
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ScenarioInformationTableDefinitionsTest.cs
    • -0
    • +1
    ./Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
  5. … 4 more files in changeset.
10:14 am

Dennis Tang <dennis.tang@deltares.nl>

Expanded reader: WTI-1925

- Expanded reader to retrieve data from the ScenarioInformation table

-- Introduced and renamed .sqlite test files

- Expanded Read object to hold the information

-- Fixed affected files

Options
    • -3
    • +117
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -1
    • +7
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicLocationConfigurationDatabase/complete.sqlite
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicLocationConfigurationDatabase/hlcdWithScenarioInformation.sqlite
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicLocationConfigurationDatabase/hlcdWithScenarioInformationInvalidData.sqlite
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicLocationConfigurationDatabase/hlcdWithScenarioInformationMissingColumn.sqlite
    • binary
    ./Ringtoets.HydraRing.IO.Test/test-data/HydraulicLocationConfigurationDatabase/hlcdWithoutScenarioInformation.sqlite
    • -1
    • +3
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
  9. … 2 more files in changeset.
8:14 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1486

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
    • -12
    • +0
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
  3. … 3 more files in changeset.
Monday 07 Jan 2019
2:04 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Improvements after review. WTI-1486

Options
    • -4
    • +4
    ./Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
  2. … 2 more files in changeset.
2:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced read object. WTI-1925

Options
    • -0
    • +86
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseSettingsTest.cs
    • -0
    • +1
    ./Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
  3. … 2 more files in changeset.
10:35 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 3406: WTI-1923

- Adjusted XMLDoc and implementation details about when the preprocessor directory should be written in the ini-script.

Options
    • -1
    • +1
    ./Ringtoets.HydraRing.Calculation.Test/Services/HydraRingInitializationServiceTest.cs
  2. … 1 more file in changeset.
9:49 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments reviews: WTI-1923

- Added license header

Options
    • -0
    • +21
    ./Ringtoets.HydraRing.Calculation.Test/Data/Input/HydraRingCalculationSettingsTest.cs
  2. … 7 more files in changeset.
Wednesday 19 Dec 2018
4:34 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review: WTI-1923

- Updated XMLDocs based on reviews 3406, 3408, 3409, 3410, 3411, 3412, 3413, 3414, 3415

- Formatting test file based on review 3406

Options
    • -7
    • +4
    ./Ringtoets.HydraRing.Calculation.Test/Data/Input/HydraRingCalculationSettingsTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.Calculation.TestUtil/HydraRingCalculationSettingsTestFactory.cs
  3. … 9 more files in changeset.
Tuesday 18 Dec 2018
2:16 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Made method private. WTI-1486

Options
    • -87
    • +0
    ./Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
  2. … 1 more file in changeset.
2:12 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Exposed ReadVersion. WTI-1486

Options
    • -0
    • +53
    ./Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
  2. … 1 more file in changeset.
2:01 pm

Robert Tangerman <robert.tangerman@deltares.nl>

removed old hrd reader. WTI-1486

Options
    • -281
    • +0
    ./Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/OldHydraulicBoundaryDatabaseReaderTest.cs
    • -1
    • +0
    ./Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
  3. … 2 more files in changeset.
1:23 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Update test data factory. WTI-1486

Options
    • -2
    • +2
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -1
    • +1
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs
8:27 am

Robert Tangerman <robert.tangerman@deltares.nl>

expanded test factories. WTI-1486

Options
    • -0
    • +26
    ./Ringtoets.HydraRing.IO.TestUtil.Test/ReadHydraulicLocationConfigurationDatabaseTestFactoryTest.cs
    • -2
    • +2
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicBoundaryDatabaseTestFactory.cs
    • -3
    • +16
    ./Ringtoets.HydraRing.IO.TestUtil/ReadHydraulicLocationConfigurationDatabaseTestFactory.cs