Riskeer / Ringtoets / Common / test

Ringtoets.Common.Service.Test

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 Dec 2018
1:08 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for WaveHeight calculations: WTI-1923

- Fixed failing tests coming from the activity:

-- Removed the temporary patch to prevent compilation errors from e67d118d775751800b5fa699f9110ce311a02405.

-- Simplified tests and mocks, as a single test should be sufficient that the correct input was sent to the calculator.

Options
    • -7
    • +8
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -52
    • +103
    ./WaveHeightCalculationActivityTest.cs
  3. … 2 more files in changeset.
11:47 am

Dennis Tang <dennis.tang@deltares.nl>

Minor improvements: WTI-1923

- Added missing tests

- Updated typos from XMLDoc

Options
    • -0
    • +18
    ./DesignWaterLevelCalculationActivityTest.cs
  2. … 4 more files in changeset.
11:33 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for WaveHeight calculations: WTI-1923

- Applied for the Service.Calculate

-- Was not applied to the validation logic yet

Note: applied a temporary "fix" for the activity to prevent compilation errors. Some tests will fail.

Options
    • -133
    • +108
    ./WaveHeightCalculationServiceTest.cs
  2. … 2 more files in changeset.
10:09 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for DesignWaterLevel calculations: WTI-1923

- Fixed failing tests:

-- Removed the temporary patch to prevent compilation errors from 51e4c5dc8ba6f7fe7f923418fa4af2d2c2f46196.

-- Simplified tests and mocks, as a single test should be sufficient that the correct input was sent to the calculator.

Options
    • -52
    • +87
    ./DesignWaterLevelCalculationActivityTest.cs
    • -7
    • +9
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  3. … 2 more files in changeset.
9:39 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for DesignWaterLevel calculations: WTI-1923

- Applied for the Service.Calculate

-- Was not applied to the validation logic yet

Note: applied a temporary "fix" for the activity to prevent compilation errors. Some tests will fail.

Options
    • -132
    • +107
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 2 more files in changeset.
Monday 10 Dec 2018
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced factory to create HydraRingCalculationSettings: WTI-1923

- Intended to be used as a conversion from the Ringtoets equivalent to the HydraRing counterpart

- Cleaned up some other files

Options
    • -0
    • +38
    ./HydraRingCalculationSettingsFactoryTest.cs
    • -0
    • +1
    ./Ringtoets.Common.Service.Test.csproj
  3. … 4 more files in changeset.
Friday 07 Dec 2018
2:41 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated WaveHeightCalculator calls: WTI-1923

- Corrected calls for the service

Options
    • -10
    • +80
    ./WaveHeightCalculationServiceTest.cs
  2. … 1 more file in changeset.
2:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated WaveHeightCalculator calls: WTI-1923

- Updated the calls directly related to the wave height

-- Excluded the grass cover erosion outwards compilation error fixes

Options
    • -1
    • +9
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -4
    • +33
    ./WaveHeightCalculationActivityTest.cs
  3. … 3 more files in changeset.
12:02 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated DesignWaterLevelCalculator calls: WTI-1923

- Updated the calls directly related to the design water level

-- Excluded the grass cover erosion outwards compilation error fixes

Options
    • -4
    • +33
    ./DesignWaterLevelCalculationActivityTest.cs
    • -10
    • +80
    ./DesignWaterLevelCalculationServiceTest.cs
    • -1
    • +10
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  4. … 4 more files in changeset.
Thursday 06 Dec 2018
2:19 pm

Dennis Tang <dennis.tang@deltares.nl>

Updated StructureCalculator calls: WTI-1923

- Performed for the generic structure service

Options
    • -7
    • +56
    ./Structures/StructuresCalculationServiceBaseTest.cs
  2. … 1 more file in changeset.
Thursday 27 Sep 2018
1:54 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changed copyright year. Paired with lubbers. WTI-1828

Options
    • -1
    • +1
    ./CalculatableActivityTest.cs
    • -1
    • +1
    ./CalculationServiceHelperTest.cs
    • -1
    • +1
    ./ClearResultsTest.cs
    • -1
    • +1
    ./DesignWaterLevelCalculationActivityTest.cs
    • -1
    • +1
    ./DesignWaterLevelCalculationServiceTest.cs
    • -1
    • +1
    ./HydraRingInputParserTest.cs
    • -1
    • +1
    ./HydraRingSettingsDatabaseHelperTest.cs
    • -1
    • +1
    ./HydraulicBoundaryDatabaseConnectionValidatorTest.cs
    • -1
    • +1
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -1
    • +1
    ./IllustrationPoints/CombinationTypeConverterTest.cs
    • -1
    • +1
    ./IllustrationPoints/FaultTreeIllustrationPointConverterTest.cs
    • -1
    • +1
    ./IllustrationPoints/GeneralResultConverterTest.cs
    • -1
    • +1
    ./IllustrationPoints/IllustrationPointNodeConverterTest.cs
    • -1
    • +1
    ./IllustrationPoints/IllustrationPointResultConverterTest.cs
    • -1
    • +1
    ./IllustrationPoints/StochastConverterTest.cs
  16. … 6081 more files in changeset.
Wednesday 26 Sep 2018
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Ran Deltares Cleanup:

- Performed for Ringtoets.Common.Service and its tests

WTI-1767

Options
    • -1
    • +1
    ./RingtoetsCommonDataSynchronizationServiceTest.cs
    • -0
    • +1
    ./SynchronizeCalculationWithForeshoreProfileHelperTest.cs
    • -4
    • +8
    ./ValidationRules/UseBreakWaterRuleTest.cs
  4. … 8 more files in changeset.
Wednesday 19 Sep 2018
1:31 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Rename AssessmentSectionHelper -> AssessmentSectionTestHelper WTI-1839

Options
    • -2
    • +2
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -17
    • +25
    ./Structures/StructuresCalculationServiceBaseTest.cs
  3. … 139 more files in changeset.
Friday 14 Sep 2018
10:07 am

Robert Tangerman <robert.tangerman@deltares.nl>

Change Categorie to Categoriegrens. WTI-1824

Options
    • -4
    • +4
    ./DesignWaterLevelCalculationActivityTest.cs
    • -2
    • +2
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
    • -5
    • +5
    ./MessageProviders/DesignWaterLevelCalculationMessageProviderTest.cs
    • -5
    • +5
    ./MessageProviders/WaveHeightCalculationMessageProviderTest.cs
    • -4
    • +4
    ./WaveHeightCalculationActivityTest.cs
  6. … 17 more files in changeset.
Friday 31 Aug 2018
2:34 pm

Elmar Kleijn

Adapted ParameterNameExtractor (no ToLower). WTI-1714

Options
    • -1
    • +1
    ./MessageProviders/DesignWaterLevelCalculationMessageProviderTest.cs
    • -1
    • +1
    ./MessageProviders/WaveHeightCalculationMessageProviderTest.cs
    • -2
    • +2
    ./ParameterNameExtractorTest.cs
  4. … 10 more files in changeset.
2:34 pm

Elmar Kleijn

Adapted ParameterNameExtractor (no ToLower). WTI-1714

Options
    • -1
    • +1
    ./MessageProviders/DesignWaterLevelCalculationMessageProviderTest.cs
    • -1
    • +1
    ./MessageProviders/WaveHeightCalculationMessageProviderTest.cs
    • -2
    • +2
    ./ParameterNameExtractorTest.cs
  4. … 10 more files in changeset.
10:20 am

Elmar Kleijn

Made some resources more consistent. WTI-1714

Options
    • -2
    • +2
    ./DesignWaterLevelCalculationActivityTest.cs
    • -2
    • +2
    ./MessageProviders/DesignWaterLevelCalculationMessageProviderTest.cs
    • -2
    • +2
    ./MessageProviders/WaveHeightCalculationMessageProviderTest.cs
    • -2
    • +2
    ./WaveHeightCalculationActivityTest.cs
  5. … 2 more files in changeset.
Thursday 16 Aug 2018
1:31 pm

Elmar Kleijn

Renamed "randvoorwaarden" into "belastingen". WTI-1714

Options
    • -1
    • +1
    ./HydraulicBoundaryDatabaseConnectionValidatorTest.cs
    • -1
    • +1
    ./Structures/StructuresCalculationServiceBaseTest.cs
  3. … 37 more files in changeset.
1:23 pm

Elmar Kleijn

Renamed "randvoorwaarden" into "belastingen". WTI-1714

Options
    • -1
    • +1
    ./Structures/StructuresCalculationServiceBaseTest.cs
  2. … 19 more files in changeset.
12:18 pm

Elmar Kleijn

Renamed "randvoorwaarden" into "belastingen". WTI-1714

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationActivityTest.cs
    • -2
    • +2
    ./HydraulicBoundaryDatabaseConnectionValidatorTest.cs
    • -2
    • +2
    ./Structures/StructuresCalculationServiceBaseTest.cs
    • -2
    • +2
    ./TargetProbabilityCalculationServiceTest.cs
    • -1
    • +1
    ./WaveHeightCalculationActivityTest.cs
  6. … 40 more files in changeset.
Wednesday 15 Aug 2018
8:09 pm

Elmar Kleijn

Got rid of "Toetspeilen". WTI-1714

Options
    • -2
    • +2
    ./DesignWaterLevelCalculationActivityTest.cs
    • -3
    • +3
    ./MessageProviders/DesignWaterLevelCalculationMessageProviderTest.cs
  3. … 2 more files in changeset.
Thursday 02 Aug 2018
10:43 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Use HydraulicBoundaryDatabaseConnectionValidator in structures service WTI-1720

Options
    • -5
    • +35
    ./Structures/StructuresCalculationServiceBaseTest.cs
  2. … 4 more files in changeset.
Thursday 19 Jul 2018
2:57 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -35
    • +10
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  2. … 3 more files in changeset.
2:57 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -35
    • +10
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  2. … 3 more files in changeset.
Wednesday 18 Jul 2018
9:14 am

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -16
    • +14
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  2. … 1 more file in changeset.
9:14 am

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -16
    • +14
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  2. … 1 more file in changeset.
Tuesday 17 Jul 2018
1:44 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -21
    • +4
    ./DesignWaterLevelCalculationActivityTest.cs
    • -21
    • +4
    ./WaveHeightCalculationActivityTest.cs
  3. … 3 more files in changeset.
1:44 pm

Elmar Kleijn

Review related changes. WTI-1732

Options
    • -21
    • +4
    ./DesignWaterLevelCalculationActivityTest.cs
    • -21
    • +4
    ./WaveHeightCalculationActivityTest.cs
  3. … 3 more files in changeset.
Wednesday 11 Jul 2018
9:48 am

Dennis Tang <dennis.tang@deltares.nl>

Implemented comments review 3057:

- Formatting

Paired with ~carloslubbers

WTI-1733

Options
    • -6
    • +12
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  2. … 1 more file in changeset.
Tuesday 10 Jul 2018
10:30 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Review related changes, update signature of factory methods WTI-1733

Options
    • -20
    • +14
    ./HydraulicBoundaryLocationCalculationActivityFactoryTest.cs
  2. … 4 more files in changeset.