Riskeer / Ringtoets / Common / test / Ringtoets.Common.Service.Test

DesignWaterLevelCalculationServiceTest.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 8
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Nov 2017
8:26 am

Robert Tangerman <robert.tangerman@deltares.nl>

Set the use preprocessor flag from within the calculation services. Related to Issue [WTI-1476]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12754 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 44f408a17fa5b1fd23da81601ab2da099cf7611b

Former-commit-id: deae48a0d2417ca39e75ed03258d54657f03dba5

Options
    • -0
    • +44
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 25 more files in changeset.
Tuesday 07 Nov 2017
4:38 pm

Elmar Kleijn

Improved some tests Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12733 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 49d716c97975a7ec16dc6c206376b1ab0309ce26

Former-commit-id: ed682530846fc364316a7ba42bba255ce5ae8a3e

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 8 more files in changeset.
10:31 am

Elmar Kleijn

Improved "validPreprocessorDirectory" Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12705 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3b9185bc40fbcc8414a389715487867471cf2384

Former-commit-id: 3eeff8b76733d78651ade65803cd873cf635f22d

Options
    • -24
    • +24
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 15 more files in changeset.
8:11 am

Elmar Kleijn

Improved validation of WaveHeightCalculationService Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12680 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d3493e2c06c496baee2d312ef65103213ff988eb

Former-commit-id: fbc498a0c0db191c6bac1154eddff5186eba174d

Options
    • -16
    • +16
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 3 more files in changeset.
7:22 am

Elmar Kleijn

Improved validation of DesignWaterLevelCalculationService Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12676 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c9dabff49263547316b21872dce18bb00bb2f26c

Former-commit-id: fcb75f97a8ac72dea0d48fd898a5b5d3b3a3c874

Options
    • -4
    • +26
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 2 more files in changeset.
Friday 03 Nov 2017
2:25 pm

Elmar Kleijn

Extended DuneErosionBoundaryCalculationService Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12603 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bebc80faa3c371545496dea76447588cb51dbd44

Former-commit-id: 5aedb07c2f78554d36febe860300ad51beb72adf

Options
    • -3
    • +3
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 4 more files in changeset.
10:12 am

Elmar Kleijn

Fixed some compilation errors Related to Issue [WTI-1477]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12582 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d1fb8c5aed81a110b06ba158bacb412b5557d0af

Former-commit-id: 51fa16ac1df9a078dbc424cefeb3873085be22d6

Options
    • -30
    • +21
    ./DesignWaterLevelCalculationServiceTest.cs
Thursday 02 Nov 2017
9:52 pm

Elmar Kleijn

Made Hydra-Ring wrapper preprocessor ready Related to Issue [WTI-1444]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12571 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7369ac6d7f05feac0add28cdd0f2274614d5865f

Former-commit-id: 6ca45261807516ee79db54deaee5010a2e346b70

Options
    • -9
    • +9
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 125 more files in changeset.
9:42 pm

Elmar Kleijn

Reverted some changes

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12570 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bf5508218b9c8ba780b0123523bd7c559bf51b1c

Former-commit-id: 2121e3718b2c9bce0aa1bf88e6044a618fc4a5e6

Options
    • -9
    • +9
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 125 more files in changeset.
1:29 pm

Elmar Kleijn

Fixed compilation failures

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/1444@12563 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a64dd3fa6b52e48204ab4bed16d5d4d0aaac0903

Former-commit-id: d377dc837539347f9d73463b7b3225c7057a479b

Options
    • -9
    • +9
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 54 more files in changeset.
Tuesday 10 Oct 2017
3:15 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, improve tests and names, update xmldoc, inline some checks Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12087 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5fb39e58032f2ab2ed02d126a9003c75c1580181

Former-commit-id: f4adacc4c9cca722a4e16e85656e7e3792c9a67a

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 20 more files in changeset.
Friday 06 Oct 2017
11:26 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, simplify calculation service tests and improve logging messages Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12039 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 103dc1fa4f8c5ee91ba04ceac3b851a2b31ce24c

Former-commit-id: bac9d51986c9579366a4bb55172ac1a7576a345d

Options
    • -165
    • +3
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 8 more files in changeset.
Friday 29 Sep 2017
1:42 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Rename AnyNonDistinct to HasDuplicates, also adapt test(helper) names. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11956 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1abe5ec281a7f33d85e8c49d85aef49802f2dc0e

Former-commit-id: 85b88e9b1beadf3b34e0bced7087d480709b0fb9

Options
    • -6
    • +6
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 22 more files in changeset.
11:29 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Change error log to warning and change text. Remove groupby call from AnyNonDistinct. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11950 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 662e9d82dfe0817a67d821e7784be330adc47eff

Former-commit-id: d2d886b12d819750c93a66f77a090466fbf69658

Options
    • -3
    • +3
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 18 more files in changeset.
Thursday 28 Sep 2017
2:09 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement validation in structures, waveheight and designwaterlevel calculation with corresponding tests. Improve GeneralResult validation with stochast check for toplevel submechanism points. Adapt old tests so they will pass. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11940 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7c5475baca39b2e50fd92cffcd066cb90035b84d

Former-commit-id: 7371f7aa9c2fe4da40051f708686731a7b20ad61

Options
    • -1
    • +217
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 12 more files in changeset.
Tuesday 25 Jul 2017
4:37 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments 1970: - Refactor HasIllustrationPoints and SetIllustrationPoints to HasGeneralResult and SetGeneralResult - ProbabilityAssessmentOutput in GrassCoverErosionInwardsOvertoppingOutput cannot be null - Improve tests for services and output objects - Move Resources to Common - Correct implementation of IllustrationPointsParserErrorMessage - Made ConvertIllustrationPointsResult private Related to Issue [WTI-1318]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10867 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 26b18ecde3707516f72159c322b00f31c74271a9

Former-commit-id: 693f5a23203efef71b2a492062c80e2d8e3202e3

Options
    • -4
    • +4
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 56 more files in changeset.
Monday 24 Jul 2017
10:37 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: Relevant comments for services - Extracted functions - Simplified tests by inlining variables

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10834 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a75ec12cf186a5719eaee92aec98e379e9a12609

Former-commit-id: 7bada798fc2e240edb3ff611fe6057f18a08aade

Options
    • -30
    • +15
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 3 more files in changeset.
Friday 21 Jul 2017
8:40 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1959: - Relevant comments for storage and core.common -- Updated XMLDoc -- Renamed function -- Improved tests

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10800 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6e23272a101a01689cf7052727e04e17e8520c98

Former-commit-id: 51c5084c3e9669df022cda3f54bdbd92bd624d51

Options
    • -1
    • +1
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 7 more files in changeset.
Thursday 20 Jul 2017
11:15 am

Dennis Tang <dennis.tang@deltares.nl>

Improved illustration points parsing logic - In case an exception occurs in the parser, set the message instead of logging. Logging will always occur regardless of whether the user selected "ShouldIllustrationPointsBeCalculated" - Cleaned up tests - Adjusted the Structures calculation services with the following logic: -- In case illustrationPoints are calculated and there is an error --> log the error as a warning -- In case illustrationPoints are not calculated and there is an error --> do not log the error

Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10782 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4e6c6ebda34a8e1580c4b81302c7e43ccc9c4d30

Former-commit-id: 6cbf649ac3ac402b2a4719c29a4760751646b747

Options
    • -3
    • +2
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 6 more files in changeset.
10:29 am

Dennis Tang <dennis.tang@deltares.nl>

Improved illustration points parsing logic - In case an exception occurs in the parser, set the message instead of logging. Logging will always occur regardless of whether the user selected "ShouldIllustrationPointsBeCalculated" - Cleaned up tests - Adjusted the HBL calculation services with the following logic: -- In case illustrationPoints are calculated and there is an error --> log the error as a warning -- In case illustrationPoints are not calculated and there is an error --> do not log the error Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10780 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 659e7f077bae7147201d04d102671920ad438c87

Former-commit-id: 86419684bf7231a4bc491f04c4913e01cbcf581a

Options
    • -10
    • +71
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 11 more files in changeset.
Tuesday 18 Jul 2017
1:06 pm

Dennis Tang <dennis.tang@deltares.nl>

Reverted error handling logic to the old situation for HBL: - Do not log exception - Make difference between the situation with and without a last error file content - Cleaned up tests

Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10749 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b8ab026259cab7153a1264a8278bf5108fb811eb

Former-commit-id: 5a8beab837d82b84b8d751f1df5f7f2007904567

Options
    • -20
    • +20
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 18 more files in changeset.
Monday 17 Jul 2017
3:32 pm

Dennis Tang <dennis.tang@deltares.nl>

Connected the Illustration point outputs with structures: - Introduced test factory for the general result to produce one with SubMechanismIllustrationPoints only - Cleaned up implementations and tests of existing (HBL) services - Moved GeneralResult from the ProbabilityAssessmentOutput to the StructuresOutput, because it should not be part of the ProbabilityAssessmentOutput Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c7c49b07b1a7f21052e5005afe1854158fd812c6

Former-commit-id: 2df669351e05f07b0265ee10f2f38567e88b76f9

Options
    • -8
    • +11
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 13 more files in changeset.
11:57 am

Dennis Tang <dennis.tang@deltares.nl>

Improved existing implementations of existing services that read illustration points: - Introduced a TestGeneralResult containing only FaultTreeIllustrationPoints to Assert behaviour on the classes that make use of the GeneralResult converters - Added TestHelper method which allows assertions on the generated Exceptions in the log - Added missing tests which assert the logging behaviour when a calculation does not converge

Related to Issue [WTI-1308]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10722 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c92d4f326db7c4987492c09192b089ad36d106ca

Former-commit-id: b417dc94e8227e4ef0963f43297b60641bd2cb8c

Options
    • -8
    • +143
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 9 more files in changeset.
Tuesday 11 Jul 2017
9:12 am

Robert Tangerman <robert.tangerman@deltares.nl>

Improved handling of faulty illustration points parsing. Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10613 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6adef418960795d27b6e2090ae1986a4a466a67e

Former-commit-id: b306ef8f133eb61477ad5eb0294f18cae47b1ad0

Options
    • -4
    • +3
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 8 more files in changeset.
Monday 10 Jul 2017
10:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Refactored HydraRingCalculatorBase so that illustration points are always parsed. Related to Issue [WTI-1354]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10586 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bf7f32809537aeefc5bde64ba1e7c01d2fe4f75a

Former-commit-id: 6ed0002e196d7eda5f1a129b802cc9c520d4feb8

Options
    • -59
    • +11
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 9 more files in changeset.
Thursday 06 Jul 2017
1:15 pm

Marten Janssen <marten.janssen@deltares.nl>

Merged IDesignWaterLevelCalculation.cs and IWaveHeightCalculation.cs Removed ICalculationMessageProvider.GetCalculationName Updated XMLdoc Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10572 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cfe13e25136b4cac64d2638227613ee0063192fa

Former-commit-id: 8194fc2bf4bad8fc11267eb6ae322d76dfcc2e62

Options
    • -38
    • +9
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 23 more files in changeset.
Wednesday 05 Jul 2017
2:51 pm

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions: - Added exception for the theoretical case when a calculator did not set a GeneralResult object when it should have. - Fixed WaveHeight test that was set up for design water level Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10567 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f8c9582278603fbbd107b2a832fbaeb95341aac1

Former-commit-id: a1a398e02fdf505bdda86daedde3c9ee05fe234b

Options
    • -0
    • +43
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 7 more files in changeset.
11:50 am

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions: - updated XMLdoc - Inlined code - Created factory for TestWindDirection, so the sources class can (re)remain sealed

Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10563 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 558ec365777dac6f65e0ed0a7becf2afd905446d

Former-commit-id: 6eb46b420417dd3c15af9d5a5be4e8a66b887772

Options
    • -146
    • +19
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 28 more files in changeset.
Tuesday 04 Jul 2017
8:27 am

Marten Janssen <marten.janssen@deltares.nl>

Review suggestions: - updated XMLdoc - changed method to property Related to Issue [WTI-1303]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10547 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 495ab60de8ec166a1449fba5eda632dfeaa62219

Former-commit-id: fefa25382e94307c30f65fb72d9024b2219dcb3a

Options
    • -31
    • +27
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 19 more files in changeset.
Friday 30 Jun 2017
9:12 am

Elmar Kleijn

Improved log messaging (removed duplication on calculation names and others) Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10512 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 7f80d5d4b3fe2cb329fc7a00666f09e0858a333c

Former-commit-id: 6a5fe69c43427946827b8a6ee1455e1649475356

Options
    • -15
    • +15
    ./DesignWaterLevelCalculationServiceTest.cs
  2. … 100 more files in changeset.