Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Review related changes.WTI-1612

  1. … 9 more files in changeset.
Fix failing tests that require an empty directory. Moved them to the scratchpad and will be disposed when the test finishes. WTI-1527

  1. … 3 more files in changeset.
Review related changes Related to Issue [WTI-1401]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@13262 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 72e0f108aada1c32ce0c08c906b68867adeb089f

Former-commit-id: 293fcf1972fa320df3629f3c3fa64ce2ccdbc4c5

    • -16
    • +13
    ./ReferenceLinesMetaReaderTest.cs
  1. … 16 more files in changeset.
Pre-condition -> Precondition Related to Issue [WTI-1463]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12798 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d1668fff7c6c904a50d220d39b419a05d800ab24

Former-commit-id: 2e5b9a2999e7624cc36a9ae7aa18c7a3ea2f9a52

  1. … 9 more files in changeset.
Cleanup of Ringtoets.Common.* Related to Issue [WTI-1463]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f9d9cdbb2feae87c9cca7154bfb0e630390ca220

Former-commit-id: 2ace285b026b153ffd67d17b506b409376d93638

    • -15
    • +13
    ./ReferenceLineMetaImporterTest.cs
  1. … 86 more files in changeset.
- Introduced testutil project to assert geometry related classes in Core.Common.Base -- Cleaned up Core.Common.TestUtil by removing Core.Common.Base related test utils to the new project

Related to Issue [WTI-1366]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12224 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2f3dfb8949cabc8267ed8de867266e4bd3eb1b01

Former-commit-id: 12a3a2c3043b142017917308689a321773725aca

  1. … 8 more files in changeset.
Read norm values from the ReferenceLineMetaSelectionDialog Related to Issue [WTI-1363]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11077 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e6b1b249af84df7bc129c0c2d84be4e125a986d1

Former-commit-id: 620d2bb4815f7ddbd0ed0ce284133f3f5a714c51

  1. … 6 more files in changeset.
Removed obsolete constructors for map layer styles. Replaced Assert.Equals(string.Empty... with Assert.IsEmpty where applicable. Improved ColorEditor. Related to Issue [WTI-1267]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10229 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0812a0a3e05ce2398afff38e2cb64cb5c1684860

Former-commit-id: 55e368ae9752d5bfe36fae8f551810251af055f3

  1. … 65 more files in changeset.
Updated resource( name)s Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10185 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: caa80ed0d43933a02165c1f2d3862399d7fc5370

Former-commit-id: 26e14907c3372f9a2083348f054a6a508ffe3f83

  1. … 14 more files in changeset.
Improved import/update messages Related to Issue [WTI-1097]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10183 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: cd7f676cc8f79a82db0dc23b912b3b594c57a26a

Former-commit-id: b66006246d984318c12742623eee3fe135551f67

  1. … 7 more files in changeset.
Updated license headers in ringtoets common. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9494 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ce33ce275ba930662636e02ef99d91e788db8757

Former-commit-id: 2a4583aeb892e314df72a61727f806c446493577

  1. … 546 more files in changeset.
Changed all local vars to consts if possible. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9448 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4684a5017b9aff9f6175f7d781cb29409f50a18e

Former-commit-id: 853c649ebc49a9513535e40ec705d5b928af0bc4

  1. … 283 more files in changeset.
Code cleanup: Ringtoets.Common Ringtoets.DuneErosion Ringtoets.HydraRing Ringtoets.Integration Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9381 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0032433ea9de109c256ed5de15ebb145f6be74fc

Former-commit-id: b5477e384031933ad12287ee6958f4f68d7f9566

    • -29
    • +28
    ./ReferenceLineMetaImporterTest.cs
    • -24
    • +23
    ./ReferenceLinesMetaReaderTest.cs
  1. … 425 more files in changeset.
* Cleanup and renaming parameters. * Replaced '\r\n' sequences with Environment.NewLine, due to the sequence being system dependent. * Updated/refreshed project references, as they weren't resolving. Related to Issue [WTI-1156]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8861 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d2754a29febccc97bced9915542f44820e442647

Former-commit-id: 5051dec4baaddf2b6720c77279b69393525e9284

  1. … 15 more files in changeset.
* Fixed typos. * Renamed MigrationNeeded to MigrationRequired. * Cleanup. * Asserting log messages improved by taking type of message into account. * Moved CriticalFileReadException from Core.Common.IO\Exceptions to Core.Common.Base\IO * Task is now disposed when disposing ActivityProgressDialog * Put license header back Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8786 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54560eb7ca6c0a99cdcf14b0406c23b9eca57311

Former-commit-id: 3b703601071d34a3cca2779d0c671f3d3ddabcd9

  1. … 122 more files in changeset.
Updated tests with GetScratchPadPath Paired with tangerma Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8554 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 76b37a547837d85495939bef575161003eb4f535

Former-commit-id: 342ddbae4245ac328542bb682fede067eb760c54

  1. … 20 more files in changeset.
Improvements after review. Related to Issue [WTI-1133]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8428 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 331f6ea0cfe5494ebfc1e4fb917ee42212e8a114

Former-commit-id: e779a2129e8567975f4f85e6bb8e1ac14bd3bc43

  1. … 26 more files in changeset.
- Used nameof methods instead of random path to create test file names. - Bubbled IOException when trying to delete a test file and it fails so we know that the file is not deleted. Paired with @janssen

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8412 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e808c5751086faf8a2b72d918e1074adb5044314

Former-commit-id: 4ba1926135f291f4b4a4ecb3debc1e7712f492c3

  1. … 25 more files in changeset.
Review related changes Related to Issue [WTI-1135]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8398 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2c7b932b25746d662f1872d0cc7da1da362c0ac2

Former-commit-id: 1f84cdb983217ed176b0641fe2e377ece56b7c2a

  1. … 22 more files in changeset.
* More tests now write to Scratchpad folder instead of some test data path (or to temp) Related to Issue [WTI-1088]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8381 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 52b0d6344e1d95add3b4fb21d5fc94c6cabdd09f

Former-commit-id: 8971cf5a936306f7e587726a9e1c205a79758950

  1. … 35 more files in changeset.
- Updated texts of ValidateFilePath Added method GetFullPath that throws only ArgumentExceptions Related to Issue [WTI-1060]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8270 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c17a15c75b90157638db91f8a04112cafacf43d8

Former-commit-id: 0eed903d451361194e8d2111d155a0755c633259

  1. … 31 more files in changeset.
Changed invocations of Path.GetInvalidFileNameChars() to Path.GetInvalidPathChars() where appropriate. Related to Issue [WTI-1060]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8252 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f68419a6786407fdbcab4cc9ecb6df2d38f9629f

Former-commit-id: 95c49baffa303369bbd953c0c443b1830e8f1bb0

  1. … 7 more files in changeset.
- Updated texts - Changed ValidateFilePath to write the chars Path.GetFileName validates against (Path.GetInvalidPathChars()) in its exception Related to Issue [WTI-1060]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8247 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 2035c7d87c781c6d0cc8fa7a3fdd46eb85a9b7e1

Former-commit-id: 0bb23d23531231bb7c07834ec39505714bb049a7

  1. … 23 more files in changeset.
Added validation for Probability of StochasticSoilProfile. Added StochasticSoilmodelUpdateException. Provided base implementation of the DoPostImport (cancelable behavior) and an overridable DoPostImportUpdates to implement just the model updates. Added Strategy postfix to IStochasticSoilModelUpdateStrategy implementations. Fixed liskov issue with StochasticSoilModelUpdateDataStrategy. Related to Issue [WTI-1070]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8026 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1b86b03430a8714c43abdb447dbf9a561426a94e

Former-commit-id: 781140c2712d3dd80e4e97c162a8455e54d8227d

  1. … 40 more files in changeset.
Incorporated comments review 1385: (Editorial) - Made the spelling of "Canceled" or "Uncancelable (opposed to "Cancelled" or "Uncancellable") consistent throughout the application.

Note:

"Cancellation" is legit U.S. spelling and therefore unchanged. "Cancelation" is not common and rarely used.

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7669 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 665e259f03237740e63d6441088354043dae52f2

Former-commit-id: 98c98ae04c081843c7bab2c55946744a8d06dad2

  1. … 35 more files in changeset.
Get rid of AffectedNonTargetObservableInstances property in FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7661 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b4399ab53f7c2aac15418f5353df3a273c66df30

Former-commit-id: ad12f9acfead5c0cbdb94f1fdff36c99392b06e6

  1. … 3 more files in changeset.
- Added NotifyProgress calls when adding data to the data model - Synchronised message values across all the importers

Note:

No tests are available to verify the cancel behaviour for the FeatureBasedMapData because it has no NotifyProgress (and consequently no SetProgress handle to set the Action it should execute during the import)

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7655 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ee82e9d839a1acfffb0ccb4ff219a30856c744e7

Former-commit-id: a79f8f2e64e63d1e9bac5672052dc8bc143bf91f

  1. … 18 more files in changeset.
Implemented Reuse tests in the concrete implementations of the FileImporterBase Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7650 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d766c4944786409b114582323cf947d60e99337f

Former-commit-id: 0ff0cb1b31a88afc319a093050888e49cd2428f5

  1. … 5 more files in changeset.
Merged revision(s) 7595-7638 from branches/WTI-490:

Merged revision(s) 7537-7594 from trunk

........

Initial commit of changes from kleijn:

- Removed HandleUserCancellingImport: FileImporter should not decide on its own how to handle Canceled actions. Consequently removed the messages that are generated by these handles

- Added logic to the importers: Cancelling is not possible when putting data on the data model. Action will always execute when it is in this stage

- Added branching paths in the activity: Import() returns false when it has failed or is cancelled

Note: failing tests will be fixed in following commits

........

Fixed tests of the FileImporterBase and Activity:

- Checks on the states are made for the 4 different paths of the Import:

-- Import successful, canceled or not

-- Import not successful, canceled or not

- Moved logging from the activity to the importer

- Added tests to assert mentioned behaviour

........

Fixed tests of the PipingSurfaceLinesCsvImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Added resource value for the ImportActivity (missing file commit)

........

Fixed tests of the PipingSoilProfilesImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned redundant brackets

........

Fixed tests of the StructuresImporter:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

Adjusted test in PipingSoilProfilesImporterTest

- Changed initial value of the result to make clear that the value is set correctly

........

Fixed tests of the ProfilesImporters:

- Added test to verify behaviour when canceling at the two stages during the import. Test regarding cancelling while Creating structures is missing

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Removed obsolete Cancel call in the PipingSoilProfilesImporterTest

........

FileImporters should call Observers in case the import was successfull AND was cancelled at an uncancellable stage.

Note: test is missing to verify this behaviour

........

Fixed tests of the ProfilesImporters:

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Temporarily removed the Cancel tests, because the FeatureBasedMapDataImporter does not have a handle for NotifyProgress. Hence, Cancel method cannot be invoked when Import is running.

........

Fixed tests of the FailureMechanismSectionsImporter:

- Added test to verify behaviour when canceling at the three stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

- Cleaned up tests in the StructuresImporterTest

........

Fixed tests of the ReferenceLineImporter:

- Added test to verify behaviour when canceling at the two stages during the import

- Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base

........

Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@7646 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 1c355702dfbd410c7c4733529d8db9e243496eba

Former-commit-id: 75c614862d018947936ef85e3775a125c425c032

  1. … 26 more files in changeset.
Fixed tests of the ReferenceLineImporter: - Added test to verify behaviour when canceling at the two stages during the import - Reverted changes related to HandleUserCancellingImport: messages are written by the LogImportCanceledMessage and handled adequately by the base Related to Issue [WTI-490]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/branches/WTI-490@7638 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 19a87c098521b229e4db615cca959bf60833a879

Former-commit-id: 5d08cb600da99361dde2bcf491347ed73ef603fc

  1. … 1 more file in changeset.