Riskeer / Application / Ringtoets / test / Application.Ringtoets.Migration.Test

RingtoetsProjectMigratorTest.cs

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 Sep 2017
4:00 pm

Marten Janssen <marten.janssen@deltares.nl>

Fixed test Related to Issue [WTI-1364]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@11614 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0a529e1aab4b212477d4901978997cee4c043a36

Former-commit-id: df9e4c7746786b2b3b055de5e7ad1cb9687139a8

Options
    • -1
    • +4
    ./RingtoetsProjectMigratorTest.cs
Tuesday 27 Jun 2017
2:50 pm

Marten Janssen <marten.janssen@deltares.nl>

Changed message "Gevolgen van de migratie van versie 5 naar versie 17.1:" to "Gevolgen van de migratie van versie 16.4 naar versie 17.1:" All TEMP tables have a prefix now, to identify them as temp fixed indenting and styling according to our standards Related to Issue [WTI-1283]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10480 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: c4c37a140abcc6d8e5f786df9d672f480b676981

Former-commit-id: 6d011cc9e658b7b3c4d2118b413f1da4b82e6ee5

Options
    • -1
    • +1
    ./RingtoetsProjectMigratorTest.cs
  2. … 3 more files in changeset.
Monday 26 Jun 2017
11:34 am

Joël van den Berg

Updated log messages generated by migration

Related to Issue [WTI-1283]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10453 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 500fd8dce454b251fffa4c4d2cbd89a44b14c19d

Former-commit-id: cbd914235124434d2bf216ed980e5eb1d28e52cf

Options
    • -22
    • +23
    ./RingtoetsProjectMigratorTest.cs
  2. … 7 more files in changeset.
10:09 am

Joël van den Berg

Hierarchy in log messages Related to Issue [WTI-1283]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10446 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: aa0477de3e07ea65979b3341705121e4a71f729f

Former-commit-id: 1323af3f3404fd44fc043a1fa07b22c007fdd6e2

Options
    • -11
    • +20
    ./RingtoetsProjectMigratorTest.cs
  2. … 4 more files in changeset.
Friday 23 Jun 2017
1:56 pm

Joël van den Berg

Updated expected migration log message Related to Issue [WTI-1283]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@10426 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 17898332d12cae1fa7a16dadd768dc848692ad67

Former-commit-id: 4cd71dbd803601810b04a6a095e77ee99f82d40a

Options
    • -1
    • +12
    ./RingtoetsProjectMigratorTest.cs
Friday 28 Apr 2017
11:37 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments review 1719: - Moved FileFilterGenerator from Core.Common.Gui to Utils: -- Added references to projects that require Utils -- Moved FileFilterGenerator related resources from Core.Common.Base to Utils -- Deleted redundant test class ExpectedFileTest - Adjusted test names - Added XML docs Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9514 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 865b42401cd8168aa4aca7e8d048391d42f2b2da

Former-commit-id: bb0f3b2386007e10aadbec61e8f57178409c38df

Options
    • -0
    • +1
    ./RingtoetsProjectMigratorTest.cs
  2. … 102 more files in changeset.
8:48 am

Robert Tangerman <robert.tangerman@deltares.nl>

Updated license headers in application. Related to Issue [WTI-1242]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9488 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bb059e969fc96666aeac8859903e186539291c50

Former-commit-id: 5555735a4426b9cb4f1db86329a7e5307ea5c911

Options
    • -1
    • +1
    ./RingtoetsProjectMigratorTest.cs
  2. … 478 more files in changeset.
Tuesday 25 Apr 2017
1:31 pm

Marten Janssen <marten.janssen@deltares.nl>

Moved SettingsHelper.cs to Core.Common.Utils Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9439 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 09302a2b2ecc70cf41788beb1eba3dbff0606111

Former-commit-id: a095bf6913555053a8171c64ca9349a31a7ddadf

Options
    • -1
    • +1
    ./RingtoetsProjectMigratorTest.cs
  2. … 61 more files in changeset.
9:13 am

Marten Janssen <marten.janssen@deltares.nl>

review related suggestions Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9429 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 31945adcc497c91c593e1911e2f97491eb44ae27

Former-commit-id: 7de59d7247c42e0c572fa25796134a00ea133286

Options
    • -6
    • +4
    ./RingtoetsProjectMigratorTest.cs
  2. … 8 more files in changeset.
Friday 21 Apr 2017
11:44 am

Marten Janssen <marten.janssen@deltares.nl>

Implemented the roundtrip of the migration log database Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9385 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e678a61ea195ad1ca4242bc1c26356a42ff0614e

Former-commit-id: 75b2d1aad704dbde13079ee7a789af4bf8bc9625

Options
    • -38
    • +124
    ./RingtoetsProjectMigratorTest.cs
  2. … 4 more files in changeset.
Thursday 20 Apr 2017
11:12 am

Marten Janssen <marten.janssen@deltares.nl>

Initial framework for logging during migration Related to Issue [WTI-1250]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@9359 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 65a0be73e41bdcc943cbb6c9aff1219a07b0386f

Former-commit-id: aa8225c3f1cf98b03cf5ebafadf307387df12a9c

Options
    • -23
    • +37
    ./RingtoetsProjectMigratorTest.cs
  2. … 14 more files in changeset.
Tuesday 21 Mar 2017
11:37 am

bouvrie <bouvrie@example.com>

* Fixed typos. * Extra test cases for GrassCoverErosionInwardsCalculationConfigurationReader. * *CalculationConfigurationReader now directly take Name, as the value cannot be null because of the schema. * Refactored checking infinity for *CalculationConfigurationReader tests. * Readded License headers. Related to Issue [WTI-1154]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8885 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e5eaaf5c85c848d2387df9da92df0e4655cdd819

Former-commit-id: 57e5fe2464d4f2bb4d43d237a48dc53e00612076

Options
    • -1
    • +1
    ./RingtoetsProjectMigratorTest.cs
  2. … 22 more files in changeset.
Thursday 16 Mar 2017
4:04 pm

Marten Janssen <marten.janssen@deltares.nl>

When user cancels, *null* is returned. Code modified as such. paired with tang_ds Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8833 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 05b96fc2f6a8444010229dc970db2d1af9a9825a

Former-commit-id: ea60c9b62a4a677e98b43559721f93bec06aed4c

Options
    • -5
    • +3
    ./RingtoetsProjectMigratorTest.cs
  2. … 1 more file in changeset.
2:07 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments tester: - Edited text of the warning dialogue message - Added log message: whenever the user cancels the migration operation in the save file dialog, a log message is printed. Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8828 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8eb59b28936a4477d37ec63c5c73718455948e54

Former-commit-id: 5ba77d769a85371c3a4c2da507c3144b3746cce1

Options
    • -1
    • +39
    ./RingtoetsProjectMigratorTest.cs
  2. … 3 more files in changeset.
Wednesday 15 Mar 2017
10:53 am

Marten Janssen <marten.janssen@deltares.nl>

Removed FileDisposeHelper from the (sometimes) failing test because the cleanup is performed by the TearDown

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8796 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 794d0c69b107ea4f1dc50bbef587e317d3dd4524

Former-commit-id: 2558b078b719a8da28d5a96140210f32595e7a36

Options
    • -27
    • +21
    ./RingtoetsProjectMigratorTest.cs
Tuesday 14 Mar 2017
4:26 pm

bouvrie <bouvrie@example.com>

* Fixed typos. * Renamed MigrationNeeded to MigrationRequired. * Cleanup. * Asserting log messages improved by taking type of message into account. * Moved CriticalFileReadException from Core.Common.IO\Exceptions to Core.Common.Base\IO * Task is now disposed when disposing ActivityProgressDialog * Put license header back Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8786 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 54560eb7ca6c0a99cdcf14b0406c23b9eca57311

Former-commit-id: 3b703601071d34a3cca2779d0c671f3d3ddabcd9

Options
    • -13
    • +14
    ./RingtoetsProjectMigratorTest.cs
  2. … 124 more files in changeset.
1:36 pm

bouvrie <bouvrie@example.com>

* Refactored IInquiryHelper such that it no longer depends on FileFilterGenerator. ** From the abstraction level point of view, it just feels incorrect to pass generators around. * Extended IInquiryHelper with a method to check if a certain optional step should be performed or not. * Refactored StorageCommandHandler to use IInquiryHelper instead of showing dialogs itself. ** This should solve some issues we're having on the build server (expected dialogs not appearing) ** Also improves consistency with other code. * CalculationConfigurationWriter.WriteDistributionProperties now based on IDictionary instead of IEnumerable<Tuple> * Cleanup Related to Issue [WTI-1153]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8775 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: dec4df77800b65c57be1a8c2b6783e85a0f2c900

Former-commit-id: 9288f6b609cf96bdfa62d1fefa7e13ba956a85b7

Options
    • -1
    • +1
    ./RingtoetsProjectMigratorTest.cs
  2. … 21 more files in changeset.
Friday 10 Mar 2017
5:12 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented review comments: - Introduced a RingtoetsProjectMigrationTestHelper: -- Can be used to retrieve file paths to latest, supported or unsupported files -- Can be used to retrieve all file paths to the supported outdated project files -- Replaced explicit project file calls with methods from the test helper Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8739 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 64aa9cbe289ee0c728cd30e9d23b962591cc0d90

Former-commit-id: 54d365a5c6b2ca6f9d0990ee27abfc38286968a1

Options
    • -22
    • +13
    ./RingtoetsProjectMigratorTest.cs
  2. … 11 more files in changeset.
2:13 pm

Dennis Tang <dennis.tang@deltares.nl>

Implemented review comments: - Removed obsolete lines in project file - Added assertions for the log level of the generated log messages - Renamed tests for naming consistency - Replaced testcases with a general source for the invalid file paths

Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8730 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: fe2b47099a1213a7a063bf08564abb9c1b5562bb

Former-commit-id: 5564b6705928765ed5bc716661f2ba635da89681

Options
    • -17
    • +28
    ./RingtoetsProjectMigratorTest.cs
  2. … 2 more files in changeset.
Wednesday 08 Mar 2017
3:06 pm

bouvrie <bouvrie@example.com>

* Refactored RingtoetsProjectMigrator to move responsibility of determining target location for migrated project to seperate method. * Fixed 2 failing tests. Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8660 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e725e71ba9d80444c8a49d6618832bee6ccd237d

Former-commit-id: 457b058abc9f8baa453a165f511492c49c895042

Options
    • -76
    • +135
    ./RingtoetsProjectMigratorTest.cs
  2. … 10 more files in changeset.
11:51 am

bouvrie <bouvrie@example.com>

* Some refactoring to RingtoetsProjectMigrator ** Now more clear return result for ShouldMigrate method between the need for migration or not or when the migration workflow is aborted. ** Moved responsibility of asking user for accepting migration from Migrate to ShouldMigrate method.

These steps have been taken as preparation to ask user for confirmation and location before starting an Activity to perform the actual migration and subsequently opening the migrated project.

Related to Issue [WTI-1049]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8654 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 3d793cf304e5f7f685b1d4341368297a7cbebdc7

Former-commit-id: 61ca241d865cafa2dc91367fd1dbf780aa790f73

Options
    • -94
    • +35
    ./RingtoetsProjectMigratorTest.cs
  2. … 7 more files in changeset.
Tuesday 07 Mar 2017
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Final changes to the migrator: - Adjusted inquiry such that it is consistent with the console application - Updated XMLDoc - Refactored RingtoetsProjectMigratorTest: -- Extracted general method which asserts the messages from the inquiry helper -- Added tests to assert behaviour of the migrator when the file to migrate to locks (unable to write) -- Replaced all DirectoryDisposeHelpers with the FileDisposeHelpers, because the SaveFileDialog interactions are now obsolete -- Some minor cleanup

Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8636 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 024a738fb573f6a4a968fba23eb6b54b859b8596

Former-commit-id: acf833a66fdc442a399e5251063d7b6baa08fc0b

Options
    • -51
    • +124
    ./RingtoetsProjectMigratorTest.cs
  2. … 4 more files in changeset.
2:51 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated the RingtoetsProjectMigrator in the StorageCommandHandler: - Fixed compilation errors of affected tests -- Introduced mocks where necessary - Ran DeltaresClean Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8618 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d546ad32067db464f96e9faa5a55aaa2b5eef6ca

Former-commit-id: c73bfdeaf395de90207b9bdedc43baf05869ac0b

Options
    • -3
    • +3
    ./RingtoetsProjectMigratorTest.cs
  2. … 14 more files in changeset.
10:37 am

Dennis Tang <dennis.tang@deltares.nl>

Removed dependency on the SaveFileDialog: - Converted tests to incorporate the IInquiryHelper - Removed unused references - Added tests to verify behaviour when migration is supposed to fail: -- Unsupported version -- Target path is the same as the source path

Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8598 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 868f6ce88911e3381c40092e7576dd62834eadbd

Former-commit-id: f4f76a6956d026ac4ba4c68a6ea82bb3b6f75fd5

Options
    • -136
    • +139
    ./RingtoetsProjectMigratorTest.cs
  2. … 2 more files in changeset.
9:31 am

Dennis Tang <dennis.tang@deltares.nl>

Investigate alternative for failing SaveDialogTests on the buildserver: - Expanded the IInquiryHelper with a GetTargetFileLocation which takes a file filter and a suggested initial name as argument - Incorporated mentioned feature in the RingtoetsProjectMigrator - Adjusted failing tests Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8594 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5dcba28f6f531f2c0cc17da88348f279e582a6e1

Former-commit-id: b94f1c1b7bad927661d5eae11fecd6e414e30e71

Options
    • -79
    • +73
    ./RingtoetsProjectMigratorTest.cs
  2. … 4 more files in changeset.
Monday 06 Mar 2017
5:15 pm

Dennis Tang <dennis.tang@deltares.nl>

Disabled the savefile dialog tests to investigate the hanging on the buildserver Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8586 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 785c6908dcbcf286ce817aa319a9c9cd588e58d5

Former-commit-id: 1c8658fa1dd2bc9d3617823aee335fa7b309a77f

Options
    • -207
    • +208
    ./RingtoetsProjectMigratorTest.cs
4:39 pm

Dennis Tang <dennis.tang@deltares.nl>

- Fixed failing tests: used Path.Combine to get the desired target path - Introduced a IMigrateProject: -- Will be used to inject the RingtoetsProjectMigrator in the StorageCommandHandler Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8584 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a91dcf37e1ce0202f18834db2b39a8f26fa28191

Former-commit-id: cced646b70846232ac83e9628e40cd58cbea1d2a

Options
    • -5
    • +5
    ./RingtoetsProjectMigratorTest.cs
  2. … 5 more files in changeset.
3:58 pm

Dennis Tang <dennis.tang@deltares.nl>

Created RingtoetsProjectMigrator: - GUI handler for determining when a file should be migrated and performs the migration - Added tests - Removed unused reference Related to Issue [WTI-1095]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@8580 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d94000a2583fb23bc4f5a00fdaf6ebe6764791a3

Former-commit-id: 23536a9d5c9045d0ba7526835a4da47bab7b0ff4

Options
    • -0
    • +440
    ./RingtoetsProjectMigratorTest.cs
  2. … 8 more files in changeset.