DAM

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 11
Total Committers: 17
Last Commit: 22 May
Commits this week: 11
Total Lines of Code (LoC): 9,848,137
Net change in LoC this week: -2,367

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading

Subversion Details

7 properties
  • bugtraq:label = Jira Issue-ID
  • bugtraq:logregex = Issue \[([A-Za-z]+-\d+)\]
  • bugtraq:message = Related to Issue [%BUGID%]
  • bugtraq:number = false
  • bugtraq:url = https://issuetracker.deltares.nl/browse/%BUGID%
  • bugtraq:warnifnoissue = true
  • tsvn:logminsize = 10
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 12 Dec 2022
6:26 pm

John Bokma

Solved the vulnerability and some code smwlls as reported by SonarQube.

Related to Issue [MWDAM-1852]

Options
    • -64
    • +101
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/DesignCalculator.cs
    • -1
    • +4
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Standard/ObjectExtensions.cs
12:34 pm

John Bokma

Restored using System.Diagnostics to ensure code builds in Debug mode too.

Related to Issue [MWDAM-1856]

Options
    • -6
    • +6
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Importers/LocationPropertyImporter.cs
10:41 am

Walter Austmann

Remove unused packages.config

Related to Issue [MWDAM-1851]

Options
    • -6
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/packages.config
    • -0
    • +4
    /DamClients/DamUI/trunk/src/Dam/Forms/app.config
10:11 am

Walter Austmann

Add explicit references to Brutile

Related to Issue [MWDAM-1851]

Options
    • -0
    • +9
    /DamClients/DamUI/trunk/src/Dam/Forms/Deltares.Dam.Forms.csproj
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/BruTile.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/BruTile.MbTiles.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/BruTile.Desktop.dll
9:03 am

Walter Austmann

Use Any instead of Count >0

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoHelperServices.cs
Friday 09 Dec 2022
12:19 pm

Walter Austmann

Remove code smell

Related to Issue [MWDAM-1851]

Options
    • -1
    • +1
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/LocationJob.cs
12:17 pm

Walter Austmann

Remove unused directives

Related to Issue [MWDAM-1851]

Options
    • -4
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/DamMapEditor.cs
    • -1
    • +0
    /DamClients/DamUI/trunk/src/Tools/LumenWorks.Framework.IO/Properties/AssemblyInfo.cs
    • -1
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/DesignCalculationPropertyControl.cs
    • -3
    • +1
    /DamClients/DamUI/trunk/src/Tools/LumenWorks.Framework.IO/Csv/Exceptions/MalformedCsvException.cs
    • -2
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/DamNewProjectDialog.cs
    • -1
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/LocationScenariosControl.cs
    • -5
    • +1
    /DamClients/DamUI/trunk/src/Tools/LumenWorks.Framework.IO/Csv/Exceptions/MissingFieldCsvException.cs
    • -1
    • +0
    /DamClients/DamUI/trunk/src/Dam/Application/Properties/AssemblyInfo.cs
    • -1
    • +0
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Importers/LocationPropertyImporter.cs
    • -6
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/WaterBoardTreeView.cs
    • -7
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/DamProjectCalculationOptionsPropertyControl.cs
    • -8
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/DikePropertyControl.cs
    • -7
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/LocationChart.cs
12:15 pm

Walter Austmann

Update DAM UI to connect with DSL 23.1.2

Related to Issue [MWDAM-1851]

Options
    • -0
    • +6
    /DamClients/DamUI/trunk/src/Dam/Forms/packages.config
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/BruTile.MbTiles.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/Deltares.Standard.Forms.Maps.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/BruTile.Desktop.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/Deltares.Standard.Forms.Maps.Version.dll
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/BruTile.dll
  7. /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer
    • -12
    • +0
    /DamClients/DamUI/trunk/src/Dam/Forms/Deltares.Dam.Forms.csproj
    • binary
    /DamClients/DamUI/trunk/lib/DSL-FormsMap/Deltares.Standard.Maps.dll
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/DotSpatial.Plugins.BruTileLayer.dll
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/BruTile.Desktop.dll
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/source.zip
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/BruTile.dll
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/DotSpatial.Plugins.zip
    • -7
    • +0
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/README.txt
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/DotSpatial.Plugins.BruTileLayer.pdb
    • binary
    /DamClients/DamUI/trunk/lib/DotSpatial.BrutileLayer/SmartThreadPool.dll
11:28 am

Walter Austmann

Remove this formatting call and simply use the input string

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
11:03 am

Walter Austmann

Replace System.NullReferenceException by ArgumentNullException

Related to Issue [MWDAM-1856]

Options
    • -7
    • +7
    /DamEngine/trunk/src/Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -9
    • +9
    /DamEngine/trunk/src/Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
10:25 am

Walter Austmann

Remove useless assignment

Related to Issue [MWDAM-1856]

Options
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
10:12 am

Walter Austmann

Remove number of parameters

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -83
    • +49
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/LineHelper.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryCurve.cs
    • -5
    • +5
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
9:11 am

Walter Austmann

Use count property

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLineCreatorBase.cs
8:59 am

Walter Austmann

Remove unnecessary cast

Related to Issue [MWDAM-1856]

Options
    • -35
    • +29
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoPropertyAttributeMap.cs
8:58 am

Walter Austmann

Rename parameters to match base class or interface declaration

Related to Issue [MWDAM-1856]

Options
    • -7
    • +7
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/Geometry2DSectionAssembler.cs
    • -32
    • +32
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/DtoDocumentAssembler.cs
    • -8
    • +8
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Assemblers/IDtoAssembler.cs
8:56 am

Walter Austmann

Remove redundant jump

Related to Issue [MWDAM-1856]

Options
    • -3
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/General/Parallel.cs
8:35 am

Walter Austmann

Remove unused setter

Related to Issue [MWDAM-1856]

Options
    • -20
    • +6
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilLayer2D.cs
Thursday 08 Dec 2022
5:20 pm

Walter Austmann

Remove unused private method in release mode

Related to Issue [MWDAM-1856]

Options
    • -0
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityCommonHelper.cs
4:52 pm

Walter Austmann

Remove unused private methods

Related to Issue [MWDAM-1856]

Options
    • -5
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/Factories/FactoryForSoilProfiles.cs
    • -19
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLine1Creator.cs
4:45 pm

Walter Austmann

Remove the unnecessary Boolean literal(s)

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Standard/ObjectCopier.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -6
    • +6
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryGenerator.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryData.cs
    • -7
    • +7
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometrySurface.cs
4:30 pm

Walter Austmann

Short-circuit logic should be used in boolean contexts

Related to Issue [MWDAM-1856]

Options
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Standard/ObjectCopier.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryPointString.cs
4:27 pm

Walter Austmann

Remove unused directives

Related to Issue [MWDAM-1856]

Options
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/TestHelpers/DamEngineDataTestFactory.cs
    • -5
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkOutput.cs
    • -3
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Standard/ThrowHelper.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.TestHelpers/XmlAdapter.cs
    • -5
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/Sensors/SensorFactory.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Interfaces/IKernelWrapper.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Io/IdValidator.cs
    • too large
    /DamEngine/trunk/src/Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineHeightAdapter.cs
    • -6
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/Physics.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/Uplift/UpliftLocationDeterminator.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilProfile1DAquiferLayerCombiner.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/DamPipingHelperTests.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data.Tests/Geotechnics/SoilProfile1DAquiferLayerCombinerTests.cs
  16. … 8 more files in changeset.
4:16 pm

Walter Austmann

Create UpliftSituation for output parameter

Related to Issue [MWDAM-1856]

Options
    • -14
    • +21
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
4:14 pm

Walter Austmann

Use getters and setters for properties

Related to Issue [MWDAM-1856]

Options
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityInwards/MacroStabilityOutputItem.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/KernelWrappers/Common/DamKernelInput.cs
    • -7
    • +7
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/UpliftSituation.cs
    • -2
    • +2
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/Point2D.cs
    • -7
    • +7
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineAdapter.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/Routines2D.cs
    • -1
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/General/Sensors/SensorPlLineCreatorSettings.cs
    • -3
    • +3
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilProfile1DAquiferLayerCombiner.cs
2:45 pm

John Bokma

Solved the bugs in SonarQube. Note that 2 (of the 10) reported bugs were actually false negatives as assessed by me and reviewed by Tom who closed these two bugs.

Related to Issue [MWDAM-1852]

Options
    • -20
    • +8
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Standard/ListExtension.cs
    • -0
    • +1754
    /DamEngine/trunk/src/Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -8
    • +7
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/SoilSurfaceProfile.cs
    • -2
    • +1
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geometry/GeometryLoop.cs
    • -1
    • +0
    /DamEngine/trunk/src/Deltares.DamEngine.Data/Geotechnics/LayerDetector.cs
10:51 am

John Bokma

Some more small code improvements.

Related to Issue [MWDAM-1792]

Options
    • -36
    • +47
    /DamClients/DamUI/trunk/src/Dam/Forms/DamSpatialEditorDecorator.cs
Wednesday 07 Dec 2022
6:40 pm

John Bokma

Some small code improvements to get rid of some of the warning, correction of typo's.

Related to Issue [MWDAM-1792]

Options
    • -1
    • +1
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
    • -26
    • +30
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/DamProject.cs
6:39 pm

John Bokma

Added ResultSlices to the extra outputfile for Stability calculations in order to be able to redraw the slices after saving and reopening a project. Corrected the drawing of the slip circle to work correctly with Bishop too (next to UpliftVan). Made sure the proper slip circle is drawn upon selection of a result in the design results table. Also made sure it shows the correct slip circle when walking through the various GeometryProbabilities (using the <- and -> arrows above the drawing window).

Related to Issue [MWDAM-1792]

Options
    • -16
    • +44
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/CsvExportData.cs
    • -1
    • +12
    /DamClients/DamUI/trunk/src/Dam/Forms/DamSpatialEditorDecorator.cs
    • -58
    • +0
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/CsvExportSoilProfileWithSurfaceLine.cs
    • -0
    • +80
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/CsvExportResultSlicesAndSoilProfileWithSurfaceLine.cs
    • -4
    • +22
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/StabilityResultSlice.cs
    • -1
    • +1
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/Deltares.Dam.Data.csproj
    • -49
    • +60
    /DamClients/DamUI/trunk/src/Dam/Forms/SlipCircleDrawingObject.cs
Tuesday 06 Dec 2022
4:12 pm

Walter Austmann

Update headers

Related to Issue [MWDAM-1844]

Options
    • -3
    • +3
    /DamClients/DamUI/trunk/src/Dam/Tests/TestHelper/TestUtils/FactoryForSoilProfileTests.cs
    • -3
    • +3
    /DamClients/DamUI/trunk/src/Dam/Tests/TestHelper/TestUtils/ObjectLeakMonitorTest.cs
    • -3
    • +3
    /DamClients/DamUI/trunk/src/Dam/Tests/TestHelper/TestUtils/MemoryLeakTestBase.cs
    • -3
    • +3
    /DamClients/DamUI/trunk/src/Dam/Tests/TestHelper/TestUtils/FactoryForSurfaceLineTests.cs
    • -3
    • +3
    /DamClients/DamUI/trunk/src/Dam/Tests/TestHelper/TestUtils/ObjectLeakMonitor.cs
12:46 pm

John Bokma

Updated the project data to accept the Bishop and Bishop/UpliftVan models for old files too.

Related to Issue [MWDAM-1844]

Options
    • -1
    • +3
    /DamClients/DamUI/trunk/src/DamClientsLibrary/Deltares.Dam.Data/DamProject.cs