Index: DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs =================================================================== diff -u -r3619 -r3622 --- DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs (.../MacroStabilityInwardsKernelWrapperTests.cs) (revision 3619) +++ DamEngine/trunk/src/Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs (.../MacroStabilityInwardsKernelWrapperTests.cs) (revision 3622) @@ -54,24 +54,28 @@ { var kernelWrapper = new MacroStabilityInwardsKernelWrapper { - FailureMechanismParametersMStab = new FailureMechanismParametersMStab() + FailureMechanismParametersMStab = new FailureMechanismParametersMStab + { + MStabParameters = + { + Model = MStabModelType.UpliftVan + } + } }; - IKernelDataInput kernelDataInput; - IKernelDataOutput kernelDataOutput; var kernelInput = CreateDamKernelInputForTest(); // Situation 1: no uplift. Expected PrepareResult.NotRelevant kernelInput.Location.ModelFactors.UpliftCriterionStability = 0.8; - var prepareResult = kernelWrapper.Prepare(kernelInput, 0, out kernelDataInput, out kernelDataOutput); + var prepareResult = kernelWrapper.Prepare(kernelInput, 0, out _, out var kernelDataOutput); Assert.AreEqual(PrepareResult.NotRelevant, prepareResult); MacroStabilityOutput damMacroStabilityOutput = (MacroStabilityOutput)kernelDataOutput; Assert.AreEqual(CalculationResult.NoRun, damMacroStabilityOutput.CalculationResult); Assert.AreEqual(false, damMacroStabilityOutput.UpliftSituation.IsUplift); // Situation 2: there is uplift and prepare succeeds. Expected PrepareResult.Successful kernelInput.Location.ModelFactors.UpliftCriterionStability = 1.4; - prepareResult = kernelWrapper.Prepare(kernelInput, 0, out kernelDataInput, out kernelDataOutput); + prepareResult = kernelWrapper.Prepare(kernelInput, 0, out _, out kernelDataOutput); Assert.AreEqual(PrepareResult.Successful, prepareResult); damMacroStabilityOutput = (MacroStabilityOutput)kernelDataOutput; Assert.AreEqual(CalculationResult.NoRun, damMacroStabilityOutput.CalculationResult); @@ -80,7 +84,7 @@ // Situation 3: prepare fails. Expected PrepareResult.Failed kernelInput.Location.ModelFactors.UpliftCriterionStability = 1.2; kernelInput.Location.SurfaceLine.CharacteristicPoints.Clear(); - prepareResult = kernelWrapper.Prepare(kernelInput, 0, out kernelDataInput, out kernelDataOutput); + prepareResult = kernelWrapper.Prepare(kernelInput, 0, out _, out kernelDataOutput); Assert.AreEqual(PrepareResult.Failed, prepareResult); damMacroStabilityOutput = (MacroStabilityOutput)kernelDataOutput; Assert.AreEqual(CalculationResult.NoRun, damMacroStabilityOutput.CalculationResult); @@ -302,8 +306,16 @@ [Test] public void TestFullCalculationSucceedsWithWarningsWithBadTangentLines() { - var kernelWrapper = new MacroStabilityInwardsKernelWrapper(); - kernelWrapper.FailureMechanismParametersMStab = new FailureMechanismParametersMStab(); + var kernelWrapper = new MacroStabilityInwardsKernelWrapper + { + FailureMechanismParametersMStab = new FailureMechanismParametersMStab + { + MStabParameters = + { + Model = MStabModelType.UpliftVan + } + } + }; // Prepare the wrapper. Result is input for the calculation dll var kernelInput = CreateDamKernelInputForTest(); @@ -334,16 +346,22 @@ { const double diff = 0.0001; - var kernelWrapper = new MacroStabilityInwardsKernelWrapper(); - kernelWrapper.FailureMechanismParametersMStab = new FailureMechanismParametersMStab(); + var kernelWrapper = new MacroStabilityInwardsKernelWrapper + { + FailureMechanismParametersMStab = new FailureMechanismParametersMStab + { + MStabParameters = + { + Model = MStabModelType.UpliftVan + } + } + }; // Prepare the wrapper. Result is input for the calculation dll - IKernelDataInput kernelDataInput; - IKernelDataOutput kernelDataOutput; var kernelInput = CreateDamKernelInputForTest(); // To ensure uplift occurs, set criterion to 1.4 kernelInput.Location.ModelFactors.UpliftCriterionStability = 1.4; - PrepareResult prepareResult = kernelWrapper.Prepare(kernelInput, 0, out kernelDataInput, out kernelDataOutput); + PrepareResult prepareResult = kernelWrapper.Prepare(kernelInput, 0, out var kernelDataInput, out var kernelDataOutput); Assert.AreEqual(PrepareResult.Successful, prepareResult); // Validate the input @@ -419,26 +437,31 @@ { const double diff = 0.0001; - var kernelWrapper = new MacroStabilityInwardsKernelWrapper(); - kernelWrapper.FailureMechanismParametersMStab = new FailureMechanismParametersMStab(); - kernelWrapper.FailureMechanismParametersMStab.MStabParameters.SearchMethod = MStabSearchMethod.BeeSwarm; + var kernelWrapper = new MacroStabilityInwardsKernelWrapper + { + FailureMechanismParametersMStab = new FailureMechanismParametersMStab + { + MStabParameters = + { + Model = MStabModelType.UpliftVan, + SearchMethod = MStabSearchMethod.BeeSwarm + } + } + }; // Prepare the wrapper. Result is input for the calculation dll - IKernelDataInput kernelDataInput; - IKernelDataOutput kernelDataOutput; var kernelInput = CreateDamKernelInputForTest(); kernelInput.DamFailureMechanismeCalculationSpecification.FailureMechanismParametersMStab.MStabParameters .SearchMethod = MStabSearchMethod.BeeSwarm; // To ensure uplift occurs, set criterion to 1.4 kernelInput.Location.ModelFactors.UpliftCriterionStability = 1.4; PrepareResult prepareResult = - kernelWrapper.Prepare(kernelInput, 0, out kernelDataInput, out kernelDataOutput); + kernelWrapper.Prepare(kernelInput, 0, out var kernelDataInput, out var kernelDataOutput); Assert.AreEqual(PrepareResult.Successful, prepareResult); // Validate the input - List messages; - var errorCount = kernelWrapper.Validate(kernelDataInput, kernelDataOutput, out messages); - Assert.IsTrue(errorCount == 0); + var errorCount = kernelWrapper.Validate(kernelDataInput, kernelDataOutput, out var messages); + Assert.AreEqual(0, errorCount); // Run the dll kernelWrapper.Execute(kernelDataInput, kernelDataOutput, out messages); @@ -480,7 +503,7 @@ Assert.IsNotNull(outputString); var output = DamXmlSerialization.LoadOutputFromXmlString(outputString); Assert.AreEqual(3, output.Results.CalculationMessages.Length, "No results available"); - Assert.IsTrue(output.Results.CalculationMessages[0].Message1.Contains("Requested kernel not implemented")); + // ToDo: Investigate if this test is still useful } [Test]