Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Oct 2017
11:26 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, simplify calculation service tests and improve logging messages Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12039 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 103dc1fa4f8c5ee91ba04ceac3b851a2b31ce24c

Former-commit-id: bac9d51986c9579366a4bb55172ac1a7576a345d

Options
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -18
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.Designer.cs
    • -5
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.resx
    • -5
    • +6
    /Ringtoets/Common/src/Ringtoets.Common.Service/Structures/StructuresCalculationServiceBase.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationService.cs
    • -165
    • +3
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
    • -286
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Structures/StructuresCalculationServiceBaseTest.cs
    • -164
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/WaveHeightCalculationServiceTest.cs
    • -1263
    • +3
    /Ringtoets/GrassCoverErosionInwards/test/Ringtoets.GrassCoverErosionInwards.Service.Test/GrassCoverErosionInwardsCalculationServiceTest.cs
11:00 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, change test names and use test objects Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12038 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 6fa9f00269e9942f554d425998fc4e5fb1f7df8d

Former-commit-id: e98c0531b4907bb6f6b5c4887605d6b89f839797

Options
    • -3
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/IllustrationPoints/TopLevelFaultTreeIllustrationPointCreateExtensionsTest.cs
    • -7
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/IllustrationPoints/IllustrationPointNodeTest.cs
    • -4
    • +2
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/IllustrationPoints/SubMechanismIllustrationPointTest.cs
10:04 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments, update XMLDocs, improve tests, move some values of resources and improve their names. Related to Issue [WTI-1391]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12037 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 21483bef12f061dd693853d6e33a8aefedfda574

Former-commit-id: 6a3f33b230f7364d277d7045a995e94a9540b0d6

Options
    • -4
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Data/IllustrationPoints/FaultTreeIllustrationPoint.cs
    • -11
    • +14
    /Ringtoets/Common/src/Ringtoets.Common.Data/IllustrationPoints/GeneralResult.cs
    • -8
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Data/IllustrationPoints/IllustrationPointNode.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Data/IllustrationPoints/SubMechanismIllustrationPoint.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
    • -5
    • +5
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.resx
    • -1
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -0
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.resx
    • -1
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/Structures/StructuresCalculationServiceBase.cs
    • -1
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/WaveHeightCalculationService.cs
    • -10
    • +8
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/IllustrationPoints/FaultTreeIllustrationPointTest.cs
    • -58
    • +26
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/IllustrationPoints/GeneralResultTest.cs
    • -8
    • +4
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/IllustrationPoints/IllustrationPointNodeTest.cs
    • -10
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/IllustrationPoints/SubMechanismIllustrationPointTest.cs
  16. … 8 more files in changeset.
Thursday 05 Oct 2017
3:52 pm

Elmar Kleijn

Improved TopLevelSubMechanismIllustrationPointProperties implementation and tests

Paired with lubbers

Related to Issue [WTI-1312]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12036 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ea9819ec391231c85446ea5f13dbc162100312df

Former-commit-id: 787da99375a41677ba708b4bad12a00132963663

Options
    • -1
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/TopLevelSubMechanismIllustrationPointProperties.cs
    • -7
    • +22
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/PropertyClasses/TopLevelSubMechanismIllustrationPointPropertiesTest.cs
3:04 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed unsupported unicode characters to align nr. of tests between the buildserver agents

Discussed with ~kleijn

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12035 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: df47312e7039933edf6aadf02940fe411115a731

Former-commit-id: 0ea85c37790a4f4b484a2bd737e134a731a9692e

Options
    • -3
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/IntegrationTests/MigrationIntegrationTest.cs
1:44 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Remove redundant conditional access. Related to Issue [WTI-1385]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12034 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a0d1540afe8c95bd72e246db0e07c0dd6a3c12e1

Former-commit-id: 5934bb875ae1d1da9a945bce31d0f5a0cc1044d4

Options
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.IO/Configurations/PipingCalculationConfigurationExporter.cs
1:31 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Added more tests for the calculator to cover case when there are only validation warnings and no errors. Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12033 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 4aa7adeeac53f109119757b1c058144699a2f2ef

Former-commit-id: 12339ce543dcef912a3213a80c9ff9b14972c917

Options
    • -6
    • +9
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/UpliftVan/UpliftVanCalculatorStubTest.cs
    • -5
    • +12
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil/Calculators/UpliftVan/UpliftVanCalculatorStub.cs
    • -2
    • +60
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
11:58 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implemented review comments, extended EnumerableExtensionsTest and GetGeneralResultWithThreeTopLevelIllustrationPointsWithChildren Related to Issue [WTI-1312]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12032 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f453f0a3d9f1001d4f0cc34c0c0a3cc70a6475bc

Former-commit-id: d560df9ca8a062e57cb4a1f08ca28f254f7e53ed

Options
    • -11
    • +52
    /Core/Common/test/Core.Common.Utils.Test/Extensions/EnumerableExtensionsTest.cs
    • -1
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsStackChartDataFactoryTest.cs
    • -4
    • +11
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/GeneralResultFaultTreeIllustrationPointViewTest.cs
11:49 am

Dennis Tang <dennis.tang@deltares.nl>

- (Re)added the SourceType byte property in the entity => Create was never writing to this property. Added missing assert to maintain behaviour - Added resource string representations for the SoilProfileType => associated properties class can use the EnumTypeConverter instead of explicit returning strings with an if-else structure Related to Issue [WTI-1433]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12031 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: a55d3e224480f04a30526a6245a75e6743f9fc73

Former-commit-id: c14ead5c2ea7e99492b6bf8281648e10bc1be400

Options
    • -1
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/Piping/PipingSoilProfileCreateExtensions.cs
    • -3
    • +8
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/Piping/PipingSoilProfileCreateExtensionsTest.cs
    • -4
    • +4
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingStochasticSoilProfileProperties.cs
    • -0
    • +18
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/Properties/Resources.Designer.cs
    • -0
    • +6
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/Properties/Resources.resx
    • -0
    • +5
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/Ringtoets.Piping.Primitives.csproj
    • -0
    • +5
    /Ringtoets/Piping/src/Ringtoets.Piping.Primitives/SoilProfileType.cs
    • -22
    • +7
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PropertyClasses/PipingStochasticSoilProfilePropertiesTest.cs
    • -0
    • +4
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/Ringtoets.Piping.Forms.Test.csproj
    • -0
    • +1
    /Ringtoets/Piping/test/Ringtoets.Piping.Primitives.Test/Ringtoets.Piping.Primitives.Test.csproj
    • -0
    • +63
    /Ringtoets/Piping/test/Ringtoets.Piping.Primitives.Test/SoilProfileTypeTest.cs
11:33 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Improve validation success check Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12030 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 571896fd824198c9a8d7a04181c9038fbeb1887e

Former-commit-id: e1ed71e82d56410deb3e3c17383c6272c05537b6

Options
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationService.cs
11:05 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement logging levels for kernel validation results Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12029 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 97285d92f8d64962e48c91e065fa45cb272cd8b4

Former-commit-id: 4bec52f250260d43fc9ab0a7ed35893a485304d4

Options
    • -0
    • +9
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Service/Properties/Resources.resx
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/IUpliftVanCalculator.cs
    • -13
    • +32
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/UpliftVanCalculator.cs
    • -0
    • +56
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/UpliftVanValidationResult.cs
    • -0
    • +32
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/UpliftVanValidationResultType.cs
    • -2
    • +5
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/UpliftVan/IUpliftVanKernel.cs
    • -2
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/UpliftVan/UpliftVanKernelWrapper.cs
    • -0
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Ringtoets.MacroStabilityInwards.KernelWrapper.csproj
    • -3
    • +10
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationService.cs
    • -1
    • +20
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Calculators/UpliftVan/UpliftVanCalculatorTest.cs
    • -0
    • +57
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Calculators/UpliftVan/UpliftVanValidationResultTest.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test/Ringtoets.MacroStabilityInwards.KernelWrapper.Test.csproj
    • -4
    • +6
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/UpliftVan/UpliftVanCalculatorStubTest.cs
    • -1
    • +26
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Kernels/UpliftVan/UpliftVanKernelStubTest.cs
  16. … 3 more files in changeset.
11:00 am

Dennis Tang <dennis.tang@deltares.nl>

Removed invalid example files for MacroStabilityInwards

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12028 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 93ecdbcc1ddc05a071d86f798e41cd399b950e49

Former-commit-id: 94fc63b8fb8a98c2e5b7d06955b8b5ed84562ac7

Options
    • -13
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Application.Ringtoets.Setup.wixproj
    • -35
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/Configuraties voor profielschematisatie 12_2_00100.xml
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/Ondergrond traject 12_2.soil
    • -7384
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/Readme.rtf
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/WBI2017_IJsselmeer_12-2_v02.config.sqlite
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/WBI2017_IJsselmeer_12-2_v02.sqlite
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/hlcd.sqlite
    • -185
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/surfacelines traject 12-2.csv
    • -185
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/surfacelines traject 12-2.krp.csv
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/vakindeling STPH traject 12-2.dbf
    • -1
    • +0
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/vakindeling STPH traject 12-2.prj
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/vakindeling STPH traject 12-2.shp
    • binary
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Macrostabiliteit binnenwaarts/vakindeling STPH traject 12-2.shx
10:06 am

Elmar Kleijn

Review related changes

Paired with lubbers

Related to Issue [WTI-1371]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12026 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 22864f51fb892a83b5296c07540f4c6d0150f769

Former-commit-id: 57f53513f3de2d025a75bfeec0a6511c8e042d09

Options
    • -14
    • +3
    /Core/Common/test/Core.Common.Controls.Test/PresentationObjects/ObservableWrappedObjectContextBaseTest.cs
    • -8
    • +8
    /Core/Common/test/Core.Common.Data.TestUtil.Test/CoreCloneAssertTest.cs
9:50 am

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, piping only): -- Added validation logic to determine whether the stochastic soil profiles are empty => If empty, exception Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12025 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 10207106ad89bcf18173ad96dc33515ef9afdfe6

Former-commit-id: 90740578a43ce5bb34875e3231ca8fec36977b84

Options
    • -2
    • +11
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -0
    • +9
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -5
    • +16
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -0
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/Application.Ringtoets.Storage.TestUtil.Test.csproj
    • -0
    • +48
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/PipingStochasticSoilProfileEntityTestFactoryTest.cs
    • -0
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -0
    • +52
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/PipingStochasticSoilProfileEntityTestFactory.cs
    • -2
    • +6
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/SoilProfile/PipingStochasticSoilModel.cs
    • -0
    • +21
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/SoilProfile/PipingStochasticSoilModelTest.cs
    • -80
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Forms.Test/PipingCalculationConfigurationHelperTest.cs
    • -0
    • +22
    /Ringtoets/Piping/test/Ringtoets.Piping.IO.Test/SoilProfiles/PipingStochasticSoilModelTransformerTest.cs
Wednesday 04 Oct 2017
5:44 pm

Dennis Tang <dennis.tang@deltares.nl>

Removed .Test reference in a test project Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12024 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 943960bde822513b9b77998e44675ba969b38b8c

Former-commit-id: 33d08a6960157b6c92ad12b42a699bdf7c4eca31

Options
    • -4
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
5:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Cleaned up some files - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, Piping only): -- Moved StochasticSoilProfile property of the PipingStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12023 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 8cf27edcf482fb639d692d19f6840bb78219dc98

Former-commit-id: dbc10165755b4dc91a62d7f21e6749d2850ed2b3

Options
    • -3
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/Piping/PipingStochasticSoilModelCreateExtensions.cs
    • -6
    • +5
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/StochasticSoilModelEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/Piping/PipingFailureMechanismCreateExtensionsTest.cs
    • -9
    • +3
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/Piping/PipingStochasticSoilModelCreateExtensionsTest.cs
    • -2
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -2
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -1
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityReadExtensionsTest.cs
    • -3
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityTestFactoryTest.cs
    • -3
    • +5
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -7
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtils.Test/DataUpdateHelperTest.cs
    • -4
    • +3
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/SoilProfiles/MacroStabilityInwardsStochasticSoilModelTransformer.cs
    • -8
    • +21
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/SoilProfile/PipingStochasticSoilModel.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Forms/PropertyClasses/PipingStochasticSoilModelProperties.cs
  16. … 20 more files in changeset.
3:20 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, MacroStabilityInwards only): -- Added validation logic to determine whether the stochastic soil profiles are empty => If empty, exception Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12022 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: da6fdf99b72f5f4507ca76cef500c9c5fe7953b3

Former-commit-id: 678db481bbd9a6b32e1dac26455628b63fa932ff

Options
    • -0
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Application.Ringtoets.Storage.Test.csproj
    • -2
    • +13
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/AssessmentSectionEntityReadExtensionsTest.cs
    • -0
    • +11
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/FailureMechanismEntityReadExtensionsTest.cs
    • -0
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsSoilProfileTwoDEntityReadExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityReadExtensionsTest.cs
    • -5
    • +17
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/Application.Ringtoets.Storage.TestUtil.Test.csproj
    • -0
    • +48
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityTestFactoryTest.cs
    • -0
    • +49
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityTestFactoryTest.cs
    • -47
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/MacroStabilityInwardsSoilLayerTwoDEntityTestFactoryTest.cs
    • -1
    • +2
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/Application.Ringtoets.Storage.TestUtil.csproj
    • -0
    • +56
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsSoilLayerTwoDEntityTestFactory.cs
    • -0
    • +52
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilProfileEntityTestFactory.cs
    • -56
    • +0
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/MacroStabilityInwardsSoilLayerTwoDEntityTestFactory.cs
    • -0
    • +10
    /Ringtoets/Common/src/Ringtoets.Common.Data/Properties/Resources.Designer.cs
  16. … 5 more files in changeset.
3:00 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implement review comments Illustration point configuration will always be written to the configuration xml, even when it has its default value. Cleaning up, move configuration assignments to proper places. Update xmldoc Related to Issue [WTI-1385]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12021 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b538258c99d1792a01a4f8528a5df67067993e59

Former-commit-id: fb0207e0562dd3d1e69b3ebfb60d501a8237c56e

Options
    • -0
    • +2
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 12-2 - Dijken en dammen - Grasbekleding erosie kruin en binnentalud/Configuraties voor profielen 1 2 en 3.xml
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 13-6 - Kunstwerken - Sas sluis/Betrouwbaarheid sluiting kunstwerk/Configuraties voor kunstwerk sas sluis.xml
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 13-6 - Kunstwerken - Sas sluis/Hoogte/Configuraties voor kunstwerk sas sluis.xml
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 13-6 - Kunstwerken - Sas sluis/Sterkte en stabiliteit puntconstructies/Configuraties voor kunstwerk sas sluis.xml
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 52-2 - Kunstwerken - Coupure worp/Betrouwbaarheid sluiting kunstwerk/Configuraties voor kunstwerk coupure worp.xml
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 52-2 - Kunstwerken - Coupure worp/Hoogte/Configuraties voor kunstwerk coupure worp.xml
    • -0
    • +1
    /Application/Ringtoets/src/Application.Ringtoets.Setup/Examples/Voorbeeld Traject 52-2 - Kunstwerken - Coupure worp/Sterkte en stabiliteit puntconstructies/Configuraties voor kunstwerk coupure worp.xml
    • -15
    • +8
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationExporter.cs
    • -2
    • +1
    /Ringtoets/ClosingStructures/src/Ringtoets.ClosingStructures.IO/Configurations/ClosingStructuresCalculationConfigurationImporter.cs
    • -0
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithForeshoreProfile.xml
    • -0
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithStructure.xml
    • -0
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/configurationWithUseBreakWater.xml
    • -0
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/folderWithSubfolderAndCalculation.xml
    • -0
    • +1
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.IO.Test/test-data/ClosingStructuresCalculationConfigurationExporter/sparseConfiguration.xml
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/Configurations/ConfigurationSchemaIdentifiers.cs
  16. … 25 more files in changeset.
2:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles, MacroStabilityInwards only): -- Moved StochasticSoilProfile property of the MacroStabilityInwardsStochasticSoilModel as a mandatory constructor argument -- Changed property from List to IEnumerable => provides readonly access of the collection -- Introduced additional test factory method --- Replaced explicit constructor calls with factory calls when possible

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12020 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 793e8b7ce8d28a571d22d61fd01a1c14280c75c6

Former-commit-id: 4ba95330a9300a647b62dfa413c36a5a581ee392

Options
    • -3
    • +3
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Create/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensions.cs
    • -6
    • +6
    /Application/Ringtoets/src/Application.Ringtoets.Storage/Read/StochasticSoilModelEntityReadExtensions.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsFailureMechanismCreateExtensionsTest.cs
    • -17
    • +12
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Create/MacroStabilityInwards/MacroStabilityInwardsStochasticSoilModelCreateExtensionsTest.cs
    • -1
    • +1
    /Application/Ringtoets/test/Application.Ringtoets.Storage.Test/Read/StochasticSoilModelEntityReadExtensionsTest.cs
    • -3
    • +5
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil.Test/RingtoetsProjectTestHelperTest.cs
    • -7
    • +4
    /Application/Ringtoets/test/Application.Ringtoets.Storage.TestUtil/RingtoetsProjectTestHelper.cs
    • -23
    • +26
    /Demo/Ringtoets/src/Demo.Ringtoets/Commands/AddNewDemoAssessmentSectionCommand.cs
    • -3
    • +4
    /Demo/Ringtoets/test/Demo.Ringtoets.Test/Commands/AddNewDemoAssessmentSectionCommandTest.cs
    • -1
    • +1
    /Ringtoets/Integration/test/Ringtoets.Integration.TestUtils.Test/DataUpdateHelperTest.cs
    • -8
    • +23
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/SoilProfile/MacroStabilityInwardsStochasticSoilModel.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsStochasticSoilModelProperties.cs
    • -4
    • +5
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.IO/SoilProfiles/MacroStabilityInwardsStochasticSoilModelTransformer.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsInputService.cs
    • -15
    • +19
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/SoilProfile/MacroStabilityInwardsStochasticSoilModelExtensionsTest.cs
  16. … 19 more files in changeset.
2:03 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Implemented review comments, added tests to the new Observable derived classes, cleanup and updated XMLDocs

Related to Issue [WTI-1371]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12019 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bd3e2a6e65e5cb160cc180a15c1f86139a616f00

Former-commit-id: 7276c846b50aba17a7b5dd1b36c436152926d18a

Options
    • -1
    • +2
    /Core/Common/src/Core.Common.Base/CloneableObservableList.cs
    • -6
    • +7
    /Core/Common/test/Core.Common.Base.Test/CloneableObservableListTest.cs
    • -7
    • +1
    /Core/Common/test/Core.Common.Base.Test/CloneableObservableTest.cs
    • -2
    • +1
    /Core/Common/test/Core.Common.Base.Test/ObservableListTest.cs
    • -2
    • +1
    /Core/Common/test/Core.Common.Base.Test/ObservableTest.cs
    • -3
    • +25
    /Core/Common/test/Core.Common.Controls.Test/PresentationObjects/ObservableWrappedObjectContextBaseTest.cs
    • -0
    • +42
    /Core/Common/test/Core.Common.Data.TestUtil.Test/CoreCloneAssertTest.cs
    • -2
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Data/GrassCoverErosionInwardsInput.cs
    • -1
    • +1
    /Ringtoets/Piping/src/Ringtoets.Piping.Data/PipingInput.cs
    • -1
    • +0
    /Ringtoets/Piping/test/Ringtoets.Piping.Data.Test/PipingInputTest.cs
1:54 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Rename variables in EnumerableExtensionsTest Related to Issue [WTI-1312]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12018 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: bc5c86aa286cb20ddcb34d514ce1084a6edc5988

Former-commit-id: 9a212249b91187ac99c6c22a137ef41012128f96

Options
    • -6
    • +6
    /Core/Common/test/Core.Common.Utils.Test/Extensions/EnumerableExtensionsTest.cs
12:56 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Expand tests to ensure functionality of dynamic closing situation visibility. Related to Issue [WTI-1312]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12017 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 0e63847bb768d6e8f2ca9a9fdc06e69a31c94cfb

Former-commit-id: a6e98550e4af8017c32709c027ddea466f6ad13e

Options
    • -1
    • +18
    /Core/Common/test/Core.Common.Utils.Test/Extensions/EnumerableExtensionsTest.cs
    • -4
    • +29
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Factories/RingtoetsStackChartDataFactoryTest.cs
    • -3
    • +15
    /Ringtoets/Common/test/Ringtoets.Common.Forms.Test/Views/IllustrationPointsTableControlTest.cs
11:26 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Change HasDuplicates to newly added HasMultipleUniqueValues for closing situation uniqueness check. Related to Issue [WTI-1312]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12016 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: e811bd079f9195e7d19f2ac90787b60e52b7b191

Former-commit-id: 0ad5c9cae2689e28ab37c8e9e75d959dd8c68df2

Options
    • -0
    • +23
    /Core/Common/src/Core.Common.Utils/Extensions/EnumerableExtensions.cs
    • -0
    • +64
    /Core/Common/test/Core.Common.Utils.Test/Extensions/EnumerableExtensionsTest.cs
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Factories/RingtoetsStackChartDataFactory.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/PropertyClasses/StructuresOutputProperties.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/GeneralResultFaultTreeIllustrationPointView.cs
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/IllustrationPointsTableControl.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/DikeHeightOutputProperties.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/OvertoppingOutputProperties.cs
    • -3
    • +3
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Forms/PropertyClasses/OvertoppingRateOutputProperties.cs
    • -11
    • +11
    /Ringtoets/Integration/src/Ringtoets.Integration.Plugin/RingtoetsPlugin.cs
10:58 am

Carlos Lubbers <carlos.lubbers@deltares.nl>

Extend CreateMacroStabilityInwardsCalculationScenarioWithValidInput and connect kernel validator Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12015 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: ae5145680b0ed18b36af333ad4cf1096e0a68da5

Former-commit-id: 1f80874499ee7597a1ddbb5824f6cb0760812a88

Options
    • -5
    • +2
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/UpliftVanCalculator.cs
    • -12
    • +87
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.TestUtil/MacroStabilityInwardsCalculationScenarioFactory.cs
    • -13
    • +32
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil.Test/Calculators/UpliftVan/UpliftVanCalculatorStubTest.cs
    • -1
    • +8
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.KernelWrapper.TestUtil/Calculators/UpliftVan/UpliftVanCalculatorStub.cs
    • -79
    • +127
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
10:02 am

Robert Tangerman <robert.tangerman@deltares.nl>

Final changes after review. Related to Issue [WTI-1377]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12014 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: b7f9a5c74f9ee902800d5a22e7271d4af8720f91

Former-commit-id: 9fce0f4806c7b22e8d6125fedba4e6f177d3c571

Options
    • -1
    • +14
    /Ringtoets/ClosingStructures/test/Ringtoets.ClosingStructures.Forms.Test/PropertyClasses/ClosingStructuresInputContextPropertiesTest.cs
    • -1
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Forms/TypeConverters/NoProbabilityValueDoubleConverter.cs
    • -3
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.Forms/Views/FailureMechanismSectionResultRow.cs
    • -2
    • +7
    /Ringtoets/HeightStructures/test/Ringtoets.HeightStructures.Forms.Test/PropertyClasses/HeightStructuresInputContextPropertiesTest.cs
    • -1
    • +29
    /Ringtoets/Integration/test/Ringtoets.Integration.Forms.Test/PropertyClasses/FailureMechanismContributionPropertiesTest.cs
    • -0
    • +10
    /Ringtoets/StabilityPointStructures/test/Ringtoets.StabilityPointStructures.Forms.Test/PropertyClasses/StabilityPointStructuresInputContextPropertiesTest.cs
7:46 am

Elmar Kleijn

Performed some small cleanups Related to Issue [WTI-1405]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12013 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 5ad173ebbbe03ffdd0a74486023c27ced90edf35

Former-commit-id: ad00dc6b4b7bf74177235ef23b3847780e094e0b

Options
    • -5
    • +5
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Data.Test/SoilProfile/MacroStabilityInwardsSoilLayerDataTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Forms.Test/PropertyClasses/MacroStabilityInwardsOutputContextPropertiesTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Plugin.Test/TreeNodeInfos/MacroStabilityInwardsFailureMechanismContextTreeNodeInfoTest.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsCalculationServiceTest.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/test/Ringtoets.MacroStabilityInwards.Service.Test/MacroStabilityInwardsDataSynchronizationServiceTest.cs
7:43 am

Elmar Kleijn

Cleaned up Primitives projects for macro stability inwards Related to Issue [WTI-1405]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12012 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: f4ee9e8163f2dee00654dbde54d7b0c922a02796

Former-commit-id: 10fb9c421e6c2618b324e2fd6946dcc2fdf433de

Options
    • -28
    • +0
    /Ringtoets.sln
    • -0
    • +121
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsGrid.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/MacroStabilityInwardsSlipPlaneUpliftVan.cs
    • -0
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Data/Ringtoets.MacroStabilityInwards.Data.csproj
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsGridProperties.cs
    • -5
    • +5
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/PropertyClasses/MacroStabilityInwardsStochasticSoilProfileProperties.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Forms/UITypeEditors/MacroStabilityInwardsInputContextStochasticSoilProfileSelectionEditor.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/UpliftVanCalculatorException.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Creators/Input/SlipPlaneUpliftVanCreator.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Kernels/UpliftVan/UpliftVanKernelWrapperException.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Plugin/FileImporter/MacroStabilityInwardsStochasticSoilModelUpdateDataStrategy.cs
    • -121
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/MacroStabilityInwardsGrid.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Primitives/Ringtoets.MacroStabilityInwards.Primitives.csproj
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/Converters/MacroStabilityInwardsSlipPlaneUpliftVanConverter.cs
    • -1
    • +0
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/Converters/UpliftVanSlipPlaneConverter.cs
  16. … 29 more files in changeset.
Tuesday 03 Oct 2017
4:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles): -- Fixed buildserver => added missing file Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12011 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: d2b0fa224f161f0190697a2dc6f435358283ca5e

Former-commit-id: 1ed2185af30f7b5c1a96a358565560dc4a3f6f3c

Options
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/modelsWithAndWithoutGeometry.soil
3:56 pm

Dennis Tang <dennis.tang@deltares.nl>

Incorporated comments dev: - Moved validation logic from readers to transformers and RT datamodel (stochastic soil profiles): -- Removed validation for the probability from the generic IO StochasticSoilModel -- Removed AddProbability function from the generic IO StochasticSoilModel -- Removed obsolete reference -- Introduced a StochasticSoilProfileTestFactory to create valid configured test objects

Related to Issue [WTI-1340]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12010 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 02b2688e6b19921c4303f911652a784de85cb953

Former-commit-id: d3b124e7165301d331a9093f4a6c45a274737cf3

Options
    • -10
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.Designer.cs
    • -3
    • +0
    /Ringtoets/Common/src/Ringtoets.Common.IO/Properties/Resources.resx
    • -4
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilModelReader.cs
    • -39
    • +2
    /Ringtoets/Common/src/Ringtoets.Common.IO/SoilProfile/StochasticSoilProfile.cs
    • -44
    • +0
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelImporterTest.cs
    • -49
    • +113
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilModelReaderTest.cs
    • -81
    • +7
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/SoilProfile/StochasticSoilProfileTest.cs
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/modelWithStochasticSoilProfile1D.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/modelWithStochasticSoilProfile2D.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/modelWithoutStochasticSoilProfiles.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/modelsWithAndWithoutStochasticSoilProfiles.soil
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/StochasticSoilModelReader/skippedStochasticSoilModel.soil
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/Ringtoets.Common.IO.TestUtil.Test.csproj
    • -2
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/StochasticSoilModelTestFactoryTest.cs
    • -0
    • +47
    /Ringtoets/Common/test/Ringtoets.Common.IO.TestUtil.Test/StochasticSoilProfileTestFactoryTest.cs
  16. … 9 more files in changeset.
3:45 pm

Carlos Lubbers <carlos.lubbers@deltares.nl>

Disable kernel validator output for now, as it throws too many errors with incorrect log level.

Related to Issue [WTI-1296]

git-svn-id: https://repos.deltares.nl/repos/WettelijkToetsInstrumentarium/trunk@12009 5a3db67b-de53-47b5-99c8-a1c30a6650e2

Former-commit-id: 77da014beb5f94b73e1eba7d88015eb3c1f5e6e9

Former-commit-id: 5ee2f39070f23a8f6ac3ef9502b39656863eee83

Options
    • -1
    • +3
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.KernelWrapper/Calculators/UpliftVan/UpliftVanCalculator.cs
    • -1
    • +1
    /Ringtoets/MacroStabilityInwards/src/Ringtoets.MacroStabilityInwards.Service/MacroStabilityInwardsCalculationService.cs