Riskeer

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit: 12 Sep 24
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 11 Dec 2018
9:39 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for DesignWaterLevel calculations: WTI-1923

- Applied for the Service.Calculate

-- Was not applied to the validation logic yet

Note: applied a temporary "fix" for the activity to prevent compilation errors. Some tests will fail.

Options
    • -2
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationActivity.cs
    • -28
    • +28
    /Ringtoets/Common/src/Ringtoets.Common.Service/DesignWaterLevelCalculationService.cs
    • -132
    • +107
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/DesignWaterLevelCalculationServiceTest.cs
8:43 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added extra error handling. WTI-1486

Options
    • binary
    /Ringtoets/Common/test/Ringtoets.Common.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/emptyschema.sqlite
    • -2
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +49
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/corruptschema.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/empty.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withoutHLCD/complete.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withoutHLCD/empty.sqlite
8:42 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added reading the data from the importer. WTI-1486

Options
    • -16
    • +21
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -2
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
8:29 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added cancellation handling after reading settings. WTI-1486

Options
    • -2
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -1
    • +2
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
8:11 am

Robert Tangerman <robert.tangerman@deltares.nl>

Use correct ReadHydraulicBoundaryDatabase in handler. WTI-1486

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
Monday 10 Dec 2018
5:14 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for Dunes: WTI-1923

- Fixed failing tests as a consequence of the refactoring of the corresponding activity.

- Updated XMLDoc

Options
    • -1
    • +1
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs
    • -3
    • +4
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/GuiServices/DuneLocationCalculationGuiServiceTest.cs
    • -40
    • +40
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Forms.Test/Views/DuneLocationCalculationsViewTest.cs
    • -5
    • +7
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneErosionFailureMechanismContextTreeNodeInfoTest.cs
    • -29
    • +25
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsContextTreeNodeInfoTest.cs
    • -4
    • +7
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Plugin.Test/TreeNodeInfos/DuneLocationCalculationsGroupContextTreeNodeInfoTest.cs
4:38 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for Dunes: WTI-1923

- Fixed failing tests:

-- Removed the temporary patch to prevent compilation errors from 7441a8f5b097aaca1f1a08c32937ebfe5e07d8b0.

-- Simplified tests and mocks, as a single test should be sufficient that the correct input was sent to the calculator.

Options
    • -15
    • +16
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivity.cs
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivityFactory.cs
    • -17
    • +21
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityFactoryTest.cs
    • -64
    • +88
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationActivityTest.cs
4:11 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced HydraulicBoundaryCalculationSettings for Dunes: WTI-1923

- Applied for the Service.Calculate

-- Was not applied to the validation logic yet

Note: applied a temporary "fix" for the activity to prevent compilation errors. Some tests will fail.

Options
    • -2
    • +2
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationActivity.cs
    • -23
    • +24
    /Ringtoets/DuneErosion/src/Ringtoets.DuneErosion.Service/DuneLocationCalculationService.cs
    • -64
    • +58
    /Ringtoets/DuneErosion/test/Ringtoets.DuneErosion.Service.Test/DuneLocationCalculationServiceTest.cs
2:34 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added progress text. WTI-1486

Options
    • -3
    • +4
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -1
    • +6
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
2:16 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1486

Options
    • -6
    • +8
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
1:56 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Added validating settings. WTI-1486

Options
    • -1
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.IO/HydraRing/HydraRingSettingsDatabaseReader.cs
    • -1
    • +39
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -2
    • +28
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • -0
    • +4
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Ringtoets.Integration.IO.Test.csproj
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withoutSettings/HLCD.sqlite
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withoutSettings/complete.sqlite
1:47 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced test helpers / utils. WTI-1923

- Introduced helpers to facilitate the testing of:

-- The conversion between Ringtoets and HydraRing objects

Options
    • -0
    • +21
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/HydraulicBoundaryCalculationSettingsTestFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil.Test/Ringtoets.Common.Data.TestUtil.Test.csproj
    • -0
    • +24
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/HydraulicBoundaryCalculationSettingsTestFactory.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.TestUtil/Ringtoets.Common.Data.TestUtil.csproj
    • -0
    • +32
    /Ringtoets/Common/test/Ringtoets.Common.Service.TestUtil/HydraRingCalculationSettingsTestHelper.cs
    • -0
    • +5
    /Ringtoets/Common/test/Ringtoets.Common.Service.TestUtil/Ringtoets.Common.Service.TestUtil.csproj
1:24 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced factory to create HydraRingCalculationSettings: WTI-1923

- Intended to be used as a conversion from the Ringtoets equivalent to the HydraRing counterpart

- Cleaned up some other files

Options
    • -3
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettings.cs
    • -3
    • +3
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettingsFactory.cs
    • -0
    • +32
    /Ringtoets/Common/src/Ringtoets.Common.Service/HydraRingCalculationSettingsFactory.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Service/Ringtoets.Common.Service.csproj
    • -0
    • +38
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/HydraRingCalculationSettingsFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Service.Test/Ringtoets.Common.Service.Test.csproj
1:22 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Changed api of the update handler. WTI-1486

Options
    • -4
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Handlers/IHydraulicBoundaryDatabaseUpdateHandler.cs
1:06 pm

Robert Tangerman <robert.tangerman@deltares.nl>

Moved resource. WTI-1486

Options
    • -2
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
1:00 pm

Dennis Tang <dennis.tang@deltares.nl>

Introduced factory to create the hydraulic calculation settings. WTI-1923

- Object represents the Ringtoets counterparts of the HydraRing calculation settings.

Options
    • -0
    • +39
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettingsFactory.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Ringtoets.Common.Data.csproj
    • -0
    • +101
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryCalculationSettingsFactoryTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
11:59 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1486

Options
    • -9
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
11:53 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added cancellation handling after reading HLCD. WTI-1486

Options
    • -1
    • +1
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -3
    • +5
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
11:44 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added notify progress when reading HLCD. WTI-1486

Options
    • -1
    • +2
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +9
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.Designer.cs
    • -0
    • +3
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Properties/Resources.resx
    • -1
    • +10
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
11:37 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added opening HLCD reader and handling errors. WTI-1486

Options
    • -5
    • +45
    /Ringtoets/Integration/src/Ringtoets.Integration.IO/Importers/HydraulicBoundaryDatabaseImporter.cs
    • -0
    • +24
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/Importers/HydraulicBoundaryDatabaseImporterTest.cs
    • binary
    /Ringtoets/Integration/test/Ringtoets.Integration.IO.Test/test-data/HydraulicBoundaryDatabaseImporter/withoutHLCD/empty.sqlite
11:16 am

Dennis Tang <dennis.tang@deltares.nl>

Introduced Ringtoets object to hold HydraRing related calculation information. WTI-1923

Options
    • -0
    • +40
    /Ringtoets/Common/src/Ringtoets.Common.Data/Hydraulics/HydraulicBoundaryCalculationSettings.cs
    • -0
    • +1
    /Ringtoets/Common/src/Ringtoets.Common.Data/Ringtoets.Common.Data.csproj
    • -0
    • +41
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Hydraulics/HydraulicBoundaryCalculationSettingsTest.cs
    • -0
    • +1
    /Ringtoets/Common/test/Ringtoets.Common.Data.Test/Ringtoets.Common.Data.Test.csproj
11:11 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added missing documentation. WTI-1486

Options
    • -2
    • +2
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
11:10 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added read method for the hydraulic location configuration database. WTI-1486

Options
    • -0
    • +10
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReader.cs
    • -1
    • +85
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/HydraulicLocationConfigurationDatabaseReaderTest.cs
10:49 am

Dennis Tang <dennis.tang@deltares.nl>

Intermediate cleanup: WTI-1923

- Cleaned up XMLDoc

- Formatted files

- Corrected mocks configurations

Options
    • -3
    • +1
    /Ringtoets/GrassCoverErosionInwards/src/Ringtoets.GrassCoverErosionInwards.Service/GrassCoverErosionInwardsCalculationService.cs
    • -4
    • +3
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.Calculation/Data/Input/HydraRingCalculationSettings.cs
    • -61
    • +61
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/HydraRingCalculatorBaseTest.cs
    • -4
    • +2
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.Calculation.Test/Calculator/StructuresCalculatorTest.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Integration.Test/StabilityStoneCoverWaveConditionsCalculationActivityIntegrationTest.cs
    • -1
    • +1
    /Ringtoets/StabilityStoneCover/test/Ringtoets.StabilityStoneCover.Service.Test/StabilityStoneCoverWaveConditionsCalculationActivityFactoryTest.cs
10:34 am

Robert Tangerman <robert.tangerman@deltares.nl>

Introduced read object for hydraulic location configuration database. WTI-1486

Options
    • -0
    • +45
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabase.cs
    • -0
    • +1
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/Ringtoets.HydraRing.IO.csproj
    • -0
    • +44
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicLocationConfigurationDatabase/ReadHydraulicLocationConfigurationDatabaseTest.cs
    • -0
    • +1
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/Ringtoets.HydraRing.IO.Test.csproj
9:47 am

Robert Tangerman <robert.tangerman@deltares.nl>

Cleanup. WTI-1486

Options
    • -16
    • +16
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
9:46 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fix rebase errors. WTI-1486

Options
    • -15
    • +13
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs
8:44 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added tests for reading locations. WTI-1486

Options
    • -0
    • +24
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
8:39 am

Robert Tangerman <robert.tangerman@deltares.nl>

Added test for parsing error while reading location. WTI-1486

Options
    • -0
    • +19
    /Ringtoets/HydraRing/test/Ringtoets.HydraRing.IO.Test/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReaderTest.cs
8:38 am

Robert Tangerman <robert.tangerman@deltares.nl>

Fix reading incomplete version. WTI-1486

Options
    • -1
    • +6
    /Ringtoets/HydraRing/src/Ringtoets.HydraRing.IO/HydraulicBoundaryDatabase/HydraulicBoundaryDatabaseReader.cs